FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

sankey - fix issue with large padding by antoinerg · Pull Request #3143 · plotly/plotly.js · GitHub

/ plotly.js Public

sankey - fix issue with large padding - #3143

Merged
antoinerg merged 7 commits into
masterfrom
3140-sankey-fix-padding
Oct 24, 2018
ConversationCommits (7)ChecksFiles changed
Merged

sankey - fix issue with large padding#3143
antoinerg merged 7 commits into
masterfrom
3140-sankey-fix-padding

Conversation

antoinerg commented Oct 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #3140 !

If node.pad is too large and overridden during the rendering step, a Lib.warn call is made to let the user know.

antoinerg changed the title include updated d3-sankey sankey - fix issue with large padding Oct 23, 2018
antoinerg commented Oct 23, 2018
View reviewed changes
Comment thread package.json Outdated
"dependencies": {
"3d-view": "^2.0.0",
"@plotly/d3-sankey": "^0.5.0",
"@plotly/d3-sankey": "git://github.com/plotly/d3-sankey.git#6f19390be0da4a81abf6f7f6cfdf5fc8dc73e583",

antoinerg Oct 23, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See the PR associated with the changes: plotly/d3-sankey#3

antoinerg commented Oct 23, 2018

Copy link
Copy Markdown
Contributor Author

Original codepen in issue: https://codepen.io/rbakker/pen/gBjXde
Updated codepen pointing to this branch's plotly.js: https://codepen.io/anon/pen/EddvvK

antoinerg commented Oct 24, 2018

Copy link
Copy Markdown
Contributor Author

@alexcjohnson What are the next steps I should do before merging this PR? Should I publish @plotly/d3-sankey to NPM?

etpinard commented Oct 24, 2018

Copy link
Copy Markdown
Contributor

Should I publish @plotly/d3-sankey to NPM?

yep 🚀 and then update the package.json and package-lock.json in this PR.

alexcjohnson commented Oct 24, 2018

Copy link
Copy Markdown
Collaborator

💃

antoinerg merged commit 36d9fb4 into master Oct 24, 2018
antoinerg deleted the 3140-sankey-fix-padding branch October 24, 2018 21:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

alexcjohnson alexcjohnson left review comments

Assignees

No one assigned

Labels

bug something broken

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL