Share chart button - #7802
Merged
marthacryan merged 26 commits intoJun 17, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
emilykl
force-pushed
the
upload-to-cloud-proto
branch
from
a487ce9 to
100da7b
Compare
May 14, 2026 17:16
…ending data to cloud
marthacryan
marked this pull request as ready for review
May 28, 2026 20:38
marthacryan
marked this pull request as draft
May 28, 2026 20:40
emilykl
commented
May 29, 2026
Comment thread
src/components/modebar/cloud_confirm.js
Outdated
emilykl
commented
May 29, 2026
Comment thread
src/plot_api/plot_config.js
Outdated
emilykl
commented
May 29, 2026
Comment thread
src/plots/plots.js
Outdated
emilykl
commented
May 29, 2026
Comment thread
src/plots/plots.js
Outdated
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
marthacryan
marked this pull request as ready for review
June 11, 2026 02:33
emilykl
commented
Jun 11, 2026
Comment thread
src/components/modebar/cloud_confirm.js
Outdated
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
emilykl
commented
Jun 15, 2026
Comment thread
src/plots/plots.js
Outdated
Comment on lines
204
to
205
| plots.sendDataToCloud = function(gd) { | ||
| var baseUrl = (window.PLOTLYENV || {}).BASE_URL || gd._context.plotlyServerURL; |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Probably better to pass in baseUrl / serverUrl as an argument, so that we don't have to duplicate this (window.PLOTLYENV || {}).BASE_URL || gd._context.plotlyServerURL logic
Sorry, something went wrong.
emilykl
commented
Jun 15, 2026
Comment thread
src/plots/plots.js
emilykl
commented
Jun 15, 2026
Comment thread
src/components/modebar/buttons.js
Outdated
emilykl
commented
Jun 15, 2026
Comment thread
test/plot-schema.json
Outdated
This reverts commit ff34976.
emilykl
force-pushed
the
upload-to-cloud-proto
branch
from
396b681 to
c1b7122
Compare
June 15, 2026 20:21
emilykl
commented
Jun 15, 2026
Comment thread
src/components/modebar/cloud_confirm.js
Outdated
emilykl
commented
Jun 15, 2026
Comment thread
src/components/modebar/buttons.js
…nto upload-to-cloud-proto
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
…nto upload-to-cloud-proto
archmoj
reviewed
Jun 18, 2026
Comment thread
src/plots/plots.js
| plots.layoutAttributes = require('./layout_attributes'); | ||
|
|
||
| var commandModule = require('./command'); | ||
| const { server } = require('karma'); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This import of a dev-dependency is not used in the source code.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This PR is missing a draft log. cc: @emilykl |
Sorry, something went wrong.
camdecoster
added a commit
that referenced
this pull request
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the existing sendDataToCloud modebar button to share the chart via Plotly Cloud rather than Chart Studio.
The button remains disabled by default. Note that the Plotly Cloud endpoint for receiving charts is not yet functional, so the full sharing feature is not yet ready, but the UI can be previewed by setting showSendToCloud: true in the plot config.
Since the Chart Studio website is no longer online, the existing "share to Cloud" logic was not functional, so this should not be a breaking change.
Codepen: https://codepen.io/marthacryan/pen/dPOmREK