fix: Remove mistakenly added import - #7848
Conversation
Sorry, something went wrong.
|
Thanks for the PR @camdecoster |
Sorry, something went wrong.
| it('can be set to other base urls', function(done) { | ||
| Plotly.newPlot(gd, [], {}, {plotlyServerURL: 'dummy'}) | ||
| .then(function() { | ||
| expect(gd._context.plotlyServerURL).toBe('dummy'); |
There was a problem hiding this comment.
This test is perfectly fine to keep
Sorry, something went wrong.
| Plotly.Plots.sendDataToCloud(gd); | ||
| expect(form.action).toContain('/dummy/external'); | ||
| expect(form.method).toBe('post'); |
There was a problem hiding this comment.
These lines should be updated to an equivalent check that works for the new upload function
Sorry, something went wrong.
| }); | ||
| afterEach(destroyGraphDiv); | ||
|
|
||
| it('has lesser priotiy then window env', function(done) { |
There was a problem hiding this comment.
Same for this test, we should keep it but update it
Sorry, something went wrong.
This reverts commit 74f178a.
|
To close the loop, I dropped the test updates from this PR and Emily will manage those in a separate PR. |
Sorry, something went wrong.
Description
Remove mistakenly added import of server from karma.
Closes #7847.
Testing
Make sure CI is passing.
Notes