FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove `*src` attributes by emilykl · Pull Request #7829 · plotly/plotly.js · GitHub

/ plotly.js Public

Remove *src attributes - #7829

Merged
emilykl merged 9 commits into
v4.0from
remove-src-attrs
Jun 10, 2026
ConversationCommits (9)ChecksFiles changed
Merged

Remove *src attributes#7829
emilykl merged 9 commits into
v4.0from
remove-src-attrs

Conversation

emilykl commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Addresses #7623

Schema attributes ending in src existed only to work with Chart Studio features, so they are no longer necessary

This PR:

  • Removes all *src attributes and associated logic
  • Removes layout.hideSources attribute which was also only needed for Chart Studio
  • Updates tests accordingly (including deleting these removed attributes from image mocks)
  • Updates typegen script
  • Regenerates plot-schema.json and generated types

emilykl force-pushed the remove-src-attrs branch from 2bc318f to 05501b7 Compare June 8, 2026 22:25
emilykl commented Jun 9, 2026
View reviewed changes
Comment thread draftlogs/7812_remove.md

emilykl Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This second draftlog is for PR #7812, which we forgot to add a draftlog for at the time.

archmoj reviewed Jun 9, 2026
View reviewed changes
Comment thread src/plots/plots.js Outdated
Comment thread test/jasmine/tests/plots_test.js Outdated
Comment thread test/jasmine/tests/plots_test.js Outdated
Comment thread draftlogs/7623_change.md Outdated
emilykl requested a review from camdecoster June 9, 2026 19:16
camdecoster approved these changes Jun 9, 2026
View reviewed changes
Comment thread draftlogs/7623_change.md Outdated
emilykl merged commit d01c5fe into v4.0 Jun 10, 2026
83 checks passed
emilykl deleted the remove-src-attrs branch June 10, 2026 16:25
emilykl mentioned this pull request Jun 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

camdecoster camdecoster approved these changes
+1 more reviewer
archmoj archmoj left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL