Add 3D breaking dam case - #473
Draft
uekerman wants to merge 1 commit into
Draft
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
As soon as #279 works and is merged, porting this one should be easy and quick. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
We now have a 2D case in the tutorials: https://precice.org/tutorials-breaking-dam-2d.html This seems to be already ported to preCICE v3. We still need to run and review it. However, it is not a priority (but would be nice to have). In principle, this would be a nice first PR to review for a new reviewer. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftover from #279
Needs major clean-up and porting to preCICE v3.
Originally contributed by @KyleDavisSA