FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Resolved Issue with Image Overlapping on Processing.org Examples Page #514 by Lavanyaa09 · Pull Request #538 · processing/processing-website · GitHub

Repository navigation

Resolved Issue with Image Overlapping on Processing.org Examples Page #514 - #538

Open
Lavanyaa09 wants to merge 1 commit into
processing:mainfrom
Lavanyaa09:resolved-Issue-on-overlapping
Open

Lavanyaa09 wants to merge 1 commit into
processing:mainfrom
Lavanyaa09:resolved-Issue-on-overlapping

Conversation

Copy link
Copy Markdown

I have observed an issue in example page of processing website where i resolved the issue by using 4 columns instead of 5 at the largest width on the examples page, leaving space on the right.
processingwebsitechanges.pdf

netlify Bot commented Jul 18, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for java-processing-faf822 ready!

Name Link
🔨 Latest commit 35506e4
🔍 Latest deploy log https://app.netlify.com/sites/java-processing-faf822/deploys/6698ea89be44b900089ad62b
😎 Deploy Preview https://deploy-preview-538--java-processing-faf822.netlify.app
📱 Preview on mobile Toggle QR Code...



Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SableRaf requested review from SableRaf and Stefterv July 18, 2024 10:30

Copy link
Copy Markdown
Collaborator

Thanks for your contribution @Lavanyaa09 ✨ Appreciate you taking the time.

I'm noticing that the changes (right side) are applied globally across breakpoint sizes.

It may actually work a the medium size but it breaks on mobile. See the screenshots below:

Copy link
Copy Markdown
Author

Hello @SableRaf,

I am pleased to inform you that the updates are now successfully functioning on the web interface globally. I will proceed to work on optimizing the mobile view and will merge the changes accordingly.

Thank you for your guidance and support.

Stefterv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The changes work so they could be merged, but I think there might be an opportunity to fix the issue with more sustainable approaches

position: fixed;
top: 130px;
right: var(--margin);
right: calc(var(--margin) - 1cm);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

centimeters have not been used yet in the codebase, please use some of the constants in the variables.css


.item {
flex-basis: calc(100% / 5);
flex: 0 0 calc(25% - 2 * var(--gutter));

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The fix works, could you research if you could scale the container element instead?

Copy link
Copy Markdown
Collaborator

@Lavanyaa09 If you're still interested in this PR, could you take a look at the comments above? Thank you for your contribution!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL