FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Resolved Issue with Image Overlapping on Processing.org Examples Page #514 by Lavanyaa09 · Pull Request #538 · processing/processing-website · GitHub

  1. processing
  2. processing-website

Repository navigation

Resolved Issue with Image Overlapping on Processing.org Examples Page #514 #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lavanyaa09 wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 7 Commits 1 Checks 0 Files changed
Open

Resolved Issue with Image Overlapping on Processing.org Examples Page #514 #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .css  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion src/components/character/Donate.module.css
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.root {
position: fixed;
top: 130px;
right: var(--margin);
right: calc(var(--margin) - 1cm);

Stefterv Jul 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

centimeters have not been used yet in the codebase, please use some of the constants in the variables.css
width: var(--col1);
float: right;
text-align: center;
Expand Down
3 changes: 2 additions & 1 deletion src/components/examples/ExamplesList.module.css
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
}

.item {
flex-basis: calc(100% / 5);
flex: 0 0 calc(25% - 2 * var(--gutter));

Stefterv Jul 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The fix works, could you research if you could scale the container element instead?
max-width: calc(25% - 2 * var(--gutter));

& h4 {
font-size: var(--text-regular);
Expand Down
Back | FazBrowse Home | New Git URL