FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fixtures: workaround PyPy bug which sometimes causes a `KeyError` crash during collection by bluetech · Pull Request #13442 · pytest-dev/pytest · GitHub

/ pytest Public

fixtures: workaround PyPy bug which sometimes causes a KeyError crash during collection - #13442

Merged
bluetech merged 1 commit into
pytest-dev:mainfrom
bluetech:reorder-items-pypy
May 28, 2025
ConversationCommits (1)ChecksFiles changed
Merged

fixtures: workaround PyPy bug which sometimes causes a KeyError crash during collection#13442
bluetech merged 1 commit into
pytest-dev:mainfrom
bluetech:reorder-items-pypy

Conversation

bluetech commented May 26, 2025

Copy link
Copy Markdown
Member

Fix #13312.

psf-chronographer Bot added the bot:chronographer:provided (automation) changelog entry is part of PR label May 26, 2025
Pierre-Sassoulas approved these changes May 26, 2025
View reviewed changes

Pierre-Sassoulas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reading the bug reports was interesting

Comment thread src/_pytest/fixtures.py Outdated
nicoddemus approved these changes May 27, 2025
View reviewed changes

nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome work @bluetech!

bluetech force-pushed the reorder-items-pypy branch from 82ba788 to aff35e6 Compare May 27, 2025 08:24

bluetech commented May 27, 2025

Copy link
Copy Markdown
Member Author

Hmm some tests started failing because of pkg_resources deprecation -- maybe new setuptools release? Didn't happen yesterday. Will check it later.

RonnyPfannschmidt commented May 27, 2025

Copy link
Copy Markdown
Member

On modern setuptools its best to not run those tests

Lets skip them if setuptools is modern

bluetech mentioned this pull request May 27, 2025
Merged
patchback Bot mentioned this pull request May 28, 2025
Merged
bluetech force-pushed the reorder-items-pypy branch from aff35e6 to 1fdcf68 Compare May 28, 2025 06:48
bluetech enabled auto-merge May 28, 2025 06:58

bluetech commented May 28, 2025

Copy link
Copy Markdown
Member Author

From what I can see we don't run coverage for pypy (probably too slow?), so the low patch coverage is expected.

bluetech disabled auto-merge May 28, 2025 08:25
bluetech merged commit f59e1ad into pytest-dev:main May 28, 2025

patchback Bot commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/f59e1ad661832f18bce28a9522be2c6d37485d09/pr-13442

Backported as #13447

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request May 28, 2025
Merge pull request #13442 from bluetech/reorder-items-pypy
c104690 
fixtures: workaround PyPy bug which sometimes causes a `KeyError` crash during collection
(cherry picked from commit f59e1ad)
patchback Bot mentioned this pull request May 28, 2025
Merged
bluetech added a commit that referenced this pull request May 28, 2025
Merge pull request #13447 from pytest-dev/patchback/backports/8.3.x/f…
b6313e0 
…59e1ad661832f18bce28a9522be2c6d37485d09/pr-13442

[PR #13442/f59e1ad6 backport][8.3.x] fixtures: workaround PyPy bug which sometimes causes a `KeyError` crash during collection
webknjaz mentioned this pull request Jun 3, 2025
Closed
bluetech deleted the reorder-items-pypy branch June 16, 2025 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicoddemus nicoddemus approved these changes
Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[regression][8.2.2] KeyError sometimes crashes test collection on PyPy while reordering fixtures

4 participants

Back | FazBrowse Home | New Git URL