fix(testing): pytest.approx correctly take account Mapping keys order to compare them - #13815
Merged
nicoddemus merged 10 commits intoJan 25, 2026
Merged
fix(testing): pytest.approx correctly take account Mapping keys order to compare them#13815nicoddemus merged 10 commits into
nicoddemus merged 10 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hello @bluetech, can I have a review here ? It should be fast. |
Sorry, something went wrong.
cmnemoi
force-pushed
the
fix/12444
branch
2 times, most recently
from
ad30e6c to
99d108b
Compare
December 2, 2025 14:37
Copy link
Copy Markdown
Contributor
Author
|
Hello @nicoddemus, thanks for your review for #13818 Here is a similar contribution to take a look to when you have the time |
Sorry, something went wrong.
nicoddemus
requested changes
Jan 13, 2026
nicoddemus
requested changes
Jan 15, 2026
Comment thread
testing/python/approx.py
nicoddemus
approved these changes
Jan 25, 2026
nicoddemus
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
…paring mappings with different keys
…er to compare them
…apping keys order
Copy link
Copy Markdown
Backport to 9.0.x: 💚 backport PR created✅ Backport PR branch: patchback/backports/9.0.x/e95a843a5dbf8af618d0714705bbf97dfdb04044/pr-13815 Backported as #14142 🤖 @patchback |
Sorry, something went wrong.
patchback Bot
pushed a commit
that referenced
this pull request
Jan 25, 2026
…pare them (#13815) This fixes an issue with `pytest.approx` where the error message incorrectly reported all elements as mismatched when comparing mappings with different key orders, even when only some values differed. The original code paired values by position rather than by key. This caused incorrect mismatch reporting when dictionary keys were in different orders. Fixes #12444 (cherry picked from commit e95a843)
6 tasks
nicoddemus
pushed a commit
that referenced
this pull request
Jan 25, 2026
…pare them (#13815) (#14142) This fixes an issue with `pytest.approx` where the error message incorrectly reported all elements as mismatched when comparing mappings with different key orders, even when only some values differed. The original code paired values by position rather than by key. This caused incorrect mismatch reporting when dictionary keys were in different orders. Fixes #12444 (cherry picked from commit e95a843) Co-authored-by: Charles-Meldhine Madi Mnemoi <63333367+cmnemoi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR fixes an issue with pytest.approx where the error message incorrectly reported all elements as mismatched when comparing mappings with different key orders, even when only some values differed.
The original code paired values by position rather than by key. This caused incorrect mismatch reporting when dictionary keys were in different orders.
This closes #12444.
Checklist