[PR #13815/e95a843a backport][9.0.x] fix(testing): pytest.approx correctly take account Mapping keys order to compare them - #14142
Merged
nicoddemus merged 1 commit intoJan 25, 2026
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…pare them (#13815) This fixes an issue with `pytest.approx` where the error message incorrectly reported all elements as mismatched when comparing mappings with different key orders, even when only some values differed. The original code paired values by position rather than by key. This caused incorrect mismatch reporting when dictionary keys were in different orders. Fixes #12444 (cherry picked from commit e95a843)
6 tasks
nicoddemus
approved these changes
Jan 25, 2026
nicoddemus
enabled auto-merge (squash)
January 25, 2026 13:02
nicoddemus
deleted the
patchback/backports/9.0.x/e95a843a5dbf8af618d0714705bbf97dfdb04044/pr-13815
branch
January 25, 2026 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #13815 as merged into main (e95a843).
Hello,
This PR fixes an issue with pytest.approx where the error message incorrectly reported all elements as mismatched when comparing mappings with different key orders, even when only some values differed.
The original code paired values by position rather than by key. This caused incorrect mismatch reporting when dictionary keys were in different orders.
This closes #12444.
Checklist