Configure `EXEEXT` hacks are interfering with `AX_C_FLOAT_WORDS_BIGENDIAN` · Issue #125698 · python/cpython · GitHub

Bug report

Bug description:

We mess up EXEEXT in configure.ac:

Lines 1323 to 1340 in cda0ec8

    
           AC_MSG_CHECKING([for --with-suffix]) 
        
           AC_ARG_WITH([suffix], 
        
                       [AS_HELP_STRING([--with-suffix=SUFFIX], [set executable suffix to SUFFIX (default is empty, yes is mapped to '.exe')])], 
        
           [ 
        
           	AS_CASE([$with_suffix], 
        
               [no], [EXEEXT=], 
        
               [yes], [EXEEXT=.exe], 
        
               [EXEEXT=$with_suffix] 
        
             ) 
        
           ], [ 
        
             AS_CASE([$ac_sys_system/$ac_sys_emscripten_target], 
        
               [Emscripten/browser*], [EXEEXT=.js], 
        
               [Emscripten/node*], [EXEEXT=.js], 
        
               [WASI/*], [EXEEXT=.wasm], 
        
               [EXEEXT=] 
        
             ) 
        
           ]) 
        
           AC_MSG_RESULT([$EXEEXT])

This creates problems1, since AX_C_FLOAT_WORDS_BIGENDIAN expects EXEEXT and ac_exeext to be the same. EXEEXT and ac_exeext are set up by AC_PROG_CC:

cpython/configure.ac

Line 1026 in cda0ec8

AC_PROG_CC

We can mitigate this by:

setting ac_exeext=$EXEEXT after L1340 in configure.ac
use another variable than EXEEXT; for example EXE_SUFFIX
other workarounds?

My gut feel regarding these is that I'd really not like to add more EXEEXT hacks, so I'd like to avoid 1). 2) should be ok, given that no-one else are depending on EXEEXT (cc. @hroncok).

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux, macOS, Other

Linked PRs

https://github.com/python/cpython/pull/125571#issuecomment-2422385731, https://github.com/python/cpython/pull/125571#issuecomment-2422414137 ↩

cc. @damelang, author of AX_C_FLOAT_WORDS_BIGENDIAN.

Another workaround, could be to move the float checks to before our EXEEXT hacks, but who knows what will break next time.

pythongh-125698: Replace EXEEXT with EXE_SUFFIX

cc. @hroncok

I am not entirely sure what's my input here supposed to be.

gh-125698: Replace EXEEXT with EXE_SUFFIX (#125699)

Revert "pythongh-125698: Replace EXEEXT with EXE_SUFFIX (python#125699)"

pythongh-125698: Restore EXEEXT in configure and Make

I am not entirely sure what's my input here supposed to be.

I just suspected a third-party consumer of our build system would like to receive a heads-up when I proposed a rename of one of the configure/Make variables.

Anyway, as I feared, the renaming broke CI, so I'm reverting it. I suggest instead to amend Dan Amelang's patch to use ac_exeext iso. EXEEXT.

gh-125698: Restore EXEEXT in configure and Make (#125758)

I amended Dan's patch to use ac_exeext in Codespaces, and can confirm that that approach works for WASI.

See python/cpython-devcontainers#30 for a proposed patch.

I amended Dan's patch to use ac_exeext in Codespaces, and can confirm that that approach works for WASI.

OTOH, most of the macros in autoconf-archive does actually use EXEEXT, and not ac_exeext, implying that if we should land python/cpython-devcontainers#30, we'd possibly run into a similar issue with another macro at a later point1. Perhaps we should just work around this in configure.ac by making sure ac_exeext is set to the same as EXEEXT.

yet another reason to switch to a more modern build system ↩

pythongh-125698: Autoconf: Sync EXEEXT and ac_exeext

gh-125698: Autoconf: Sync EXEEXT and ac_exeext (#125995)

pythongh-125698: Autoconf: Sync EXEEXT and ac_exeext (pythonGH-125995)

Landed on the following solution:

gh-125698: Autoconf: Sync EXEEXT and ac_exeext #125995

Automerge enabled for the backports. Closing this as completed.

[3.12] gh-125698: Autoconf: Sync EXEEXT and ac_exeext (GH-125995) (#1…

[3.13] gh-125698: Autoconf: Sync EXEEXT and ac_exeext (GH-125995) (#1…

pythongh-125698: Replace EXEEXT with EXE_SUFFIX (python#125699)

pythongh-125698: Restore EXEEXT in configure and Make (python#125758)

pythongh-125698: Autoconf: Sync EXEEXT and ac_exeext (python#125995)

Configure `EXEEXT` hacks are interfering with `AX_C_FLOAT_WORDS_BIGENDIAN` · Issue #125698 · python/cpython · GitHub

Repository navigation

Configure EXEEXT hacks are interfering with AX_C_FLOAT_WORDS_BIGENDIAN #125698

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	AC_MSG_CHECKING([for --with-suffix])
	AC_ARG_WITH([suffix],
	[AS_HELP_STRING([--with-suffix=SUFFIX], [set executable suffix to SUFFIX (default is empty, yes is mapped to '.exe')])],
	[
	AS_CASE([$with_suffix],
	[no], [EXEEXT=],
	[yes], [EXEEXT=.exe],
	[EXEEXT=$with_suffix]
	)
	], [
	AS_CASE([$ac_sys_system/$ac_sys_emscripten_target],
	[Emscripten/browser*], [EXEEXT=.js],
	[Emscripten/node*], [EXEEXT=.js],
	[WASI/*], [EXEEXT=.wasm],
	[EXEEXT=]
	)
	])
	AC_MSG_RESULT([$EXEEXT])

Configure `EXEEXT` hacks are interfering with `AX_C_FLOAT_WORDS_BIGENDIAN` · Issue #125698 · python/cpython · GitHub

Repository navigation

Configure EXEEXT hacks are interfering with AX_C_FLOAT_WORDS_BIGENDIAN #125698

Description

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Footnotes

Activity

erlend-aasland commented on Oct 18, 2024

erlend-aasland commented on Oct 18, 2024

hroncok commented on Oct 18, 2024

erlend-aasland commented on Oct 20, 2024

erlend-aasland commented on Oct 20, 2024

erlend-aasland commented on Oct 20, 2024

erlend-aasland commented on Oct 21, 2024

Footnotes

erlend-aasland commented on Oct 26, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions