FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-22: Amend float detection patch to use private Autoconf variables by erlend-aasland · Pull Request #30 · python/cpython-devcontainers · GitHub

  1. python
  2. cpython-devcontainers

Repository navigation

gh-22: Amend float detection patch to use private Autoconf variables - #30

Closed
erlend-aasland wants to merge 1 commit into
python:mainfrom
erlend-aasland:amend-float-detection
ConversationCommits (1)ChecksFiles changed
Closed

gh-22: Amend float detection patch to use private Autoconf variables#30
erlend-aasland wants to merge 1 commit into
python:mainfrom
erlend-aasland:amend-float-detection

Conversation

erlend-aasland commented Oct 20, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

erlend-aasland linked an issue Oct 20, 2024 that may be closed by this pull request
Patch autoconf-archive with an updated variant of AX_C_FLOAT_WORDS_BIGENDIAN #22
Closed
erlend-aasland mentioned this pull request Oct 20, 2024
Closed

erlend-aasland commented Oct 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@damelang: I think this is a safer choice; what do you think of upstreaming this amendment?

corona10 commented Oct 20, 2024

Copy link
Copy Markdown
Member

Hmm by the way, please take a look at this issue too: #29
Since we already upgrade the autoconf image to 24.04, we may need to modify related CI code or should be fixed from this repo side.

erlend-aasland commented Oct 20, 2024

Copy link
Copy Markdown
Collaborator Author

Thanks for the review, Donghee. I'll give Dan a chance to chime in before landing this.

erlend-aasland commented Oct 21, 2024

Copy link
Copy Markdown
Collaborator Author

Actually, I don't think we should do this; most macros in autoconf-archive use EXEEXT and not ac_exeext. Perhaps a workaround in configure.ac is the best solution after all.

erlend-aasland marked this pull request as draft October 21, 2024 08:17

erlend-aasland commented Oct 25, 2024

Copy link
Copy Markdown
Collaborator Author

[...] Perhaps a workaround in configure.ac is the best solution after all.

See:

erlend-aasland deleted the amend-float-detection branch October 25, 2024 22:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Patch autoconf-archive with an updated variant of AX_C_FLOAT_WORDS_BIGENDIAN

2 participants

Back | FazBrowse Home | New Git URL