FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-125698: Replace EXEEXT with EXE_SUFFIX by erlend-aasland · Pull Request #125699 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-125698: Replace EXEEXT with EXE_SUFFIX - #125699

Merged
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:autoconf-shenanigans
Oct 20, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-125698: Replace EXEEXT with EXE_SUFFIX#125699
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:autoconf-shenanigans

Conversation

erlend-aasland commented Oct 18, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Oct 18, 2024
Closed

erlend-aasland commented Oct 18, 2024

Copy link
Copy Markdown
Contributor Author

We might need a NEWS entry for this for the build section. I'm not sure yet.

ned-deily approved these changes Oct 18, 2024
View reviewed changes

ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

From a visual inspection (without any build testing), the changes look OK and harmless to me. It appears that the current EXEEXT is used only for creating the configured Makefile and doesn't appear as a variable directly in the finished product. So that doesn't seem like it counts as an external interface requiring documentation.

erlend-aasland commented Oct 18, 2024

Copy link
Copy Markdown
Contributor Author

Thank for the review, Ned. Yeah, that was my conclusion as well.

erlend-aasland commented Oct 18, 2024

Copy link
Copy Markdown
Contributor Author

I'll land this in a couple of days, in case anyone has objections.

erlend-aasland merged commit e924bb6 into python:main Oct 20, 2024
erlend-aasland deleted the autoconf-shenanigans branch October 20, 2024 01:10
hugovk added a commit to hugovk/cpython that referenced this pull request Oct 20, 2024
Revert "pythongh-125698: Replace EXEEXT with EXE_SUFFIX (python#125699)"
f0449ff 
This reverts commit e924bb6.
hugovk mentioned this pull request Oct 20, 2024
Closed

erlend-aasland commented Oct 20, 2024

Copy link
Copy Markdown
Contributor Author

Reverted in:

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
pythongh-125698: Replace EXEEXT with EXE_SUFFIX (python#125699)
210a2c9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ned-deily ned-deily approved these changes
corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL