FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-100538: Create a workflow for verifying bundled libexpat files by illia-v · Pull Request #100539 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-100538: Create a workflow for verifying bundled libexpat files - #100539

Closed
illia-v wants to merge 4 commits into
python:mainfrom
illia-v:verify-expat
ConversationCommits (4)ChecksFiles changed
Closed

gh-100538: Create a workflow for verifying bundled libexpat files#100539
illia-v wants to merge 4 commits into
python:mainfrom
illia-v:verify-expat

Conversation

illia-v commented Dec 26, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Tags of libexpat releases are signed and GitHub runs a verification process on them.

I added a check of the verification status retrieved via GitHub's API. If the check succeeds, the script downloads a release source code and compares content of bundled files to the source.

Since a few lines are added to Modules/expat/expat_external.h, I moved them to the top of the file and the script skips them.

bedevere-bot mentioned this pull request Dec 26, 2022
Closed

sobolevn commented Dec 27, 2022

Copy link
Copy Markdown
Member

You don't need news for build tools :)

illia-v commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

@sobolevn I removed the news entry

hartwork mentioned this pull request Feb 14, 2024
Merged
picnixz reviewed Oct 4, 2025
View reviewed changes
Comment thread Modules/expat/expat_external.h
@@ -1,3 +1,7 @@
/* Namespace external symbols to allow multiple libexpat version to

picnixz Oct 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This one is should not be needed. It's already included below.

picnixz commented Oct 4, 2025

Copy link
Copy Markdown
Member

More generally, I'm not sure we actually need this step. Aren't we already doing this with SBOM checks?

StanFromIreland commented Feb 28, 2026

Copy link
Copy Markdown
Member

Aren't we already doing this with SBOM checks?

We aren't verifying that the files in the repository are the same as the ones in the release.

StanFromIreland mentioned this pull request Feb 28, 2026
Merged

StanFromIreland commented Feb 28, 2026

Copy link
Copy Markdown
Member

I propose a simpler alternative: #145359

gpshead commented Mar 1, 2026

Copy link
Copy Markdown
Member

closing as the alternative PR merged. thanks though, this is a useful thing for us to have!

gpshead closed this Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
hugovk Awaiting requested review from hugovk hugovk is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
sethmlarson Awaiting requested review from sethmlarson

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL