FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-100538: Add workflow to verify bundled libexpat by StanFromIreland · Pull Request #145359 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-100538: Add workflow to verify bundled libexpat - #145359

Merged
gpshead merged 6 commits into
python:mainfrom
StanFromIreland:verify-expat
Mar 1, 2026
ConversationCommits (6)ChecksFiles changed
Merged

gh-100538: Add workflow to verify bundled libexpat#145359
gpshead merged 6 commits into
python:mainfrom
StanFromIreland:verify-expat

Conversation

StanFromIreland commented Feb 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Feb 28, 2026
Closed
StanFromIreland marked this pull request as ready for review February 28, 2026 12:26

StanFromIreland commented Feb 28, 2026

Copy link
Copy Markdown
Member Author

CC @hartwork @gpshead @sethmlarson

StanFromIreland mentioned this pull request Feb 28, 2026
Closed
hartwork reviewed Mar 1, 2026
View reviewed changes

hartwork left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@StanFromIreland makes sense to me! 👍

hugovk commented Mar 1, 2026

Copy link
Copy Markdown
Member

Is it worth combining this verify-expat.yml with the existing verify-ensurepip-wheels.yml?

StanFromIreland commented Mar 1, 2026

Copy link
Copy Markdown
Member Author

Is it worth combining this verify-expat.yml with the existing verify-ensurepip-wheels.yml?

IMO, no. It won't save us much time (~5 seconds, but the workflow only takes a few (~10) seconds in total), and one check will always be unnecessarily run.

gpshead approved these changes Mar 1, 2026
View reviewed changes

gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thanks for adding this, useful!

gpshead merged commit c9a5d9a into python:main Mar 1, 2026
52 checks passed
gpshead added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Mar 1, 2026

miss-islington-app Bot commented Mar 1, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Mar 1, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 1, 2026
pythongh-100538: Add workflow to verify bundled libexpat (pythonGH-14…
5e5cde6 
…5359)

Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 1, 2026
pythongh-100538: Add workflow to verify bundled libexpat (pythonGH-14…
a744028 
…5359)

Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app Bot commented Mar 1, 2026

Copy link
Copy Markdown

GH-145400 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 1, 2026

bedevere-app Bot commented Mar 1, 2026

Copy link
Copy Markdown

GH-145401 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 1, 2026

gpshead commented Mar 1, 2026

Copy link
Copy Markdown
Member

(if the backports work, i'll merge them, if not, no worries, having this in main is the most important part)

StanFromIreland deleted the verify-expat branch March 1, 2026 19:50

StanFromIreland commented Mar 1, 2026

Copy link
Copy Markdown
Member Author

having this in main is the most important part

I would suggest also the security branches, since they require manual backports?

gpshead pushed a commit that referenced this pull request Mar 1, 2026
[3.13] gh-100538: Add workflow to verify bundled libexpat (GH-145359) (…
3682654 
…#145400)

gh-100538: Add workflow to verify bundled libexpat (GH-145359)

Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
gpshead pushed a commit that referenced this pull request Mar 1, 2026
[3.14] gh-100538: Add workflow to verify bundled libexpat (GH-145359) (…
c443bab 
…#145401)

gh-100538: Add workflow to verify bundled libexpat (GH-145359)

Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

miss-islington-app Bot commented Mar 2, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington-app Bot commented Mar 2, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington-app Bot commented Mar 2, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2026
pythongh-100538: Add workflow to verify bundled libexpat (pythonGH-14…
0564fd8 
…5359)

Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2026
pythongh-100538: Add workflow to verify bundled libexpat (pythonGH-14…
69ecfc9 
…5359)

Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app Bot commented Mar 2, 2026

Copy link
Copy Markdown

GH-145407 is a backport of this pull request to the 3.10 branch.

bedevere-app Bot commented Mar 2, 2026

Copy link
Copy Markdown

GH-145408 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Mar 2, 2026

bedevere-app Bot commented Mar 2, 2026

Copy link
Copy Markdown

GH-145409 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 2, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2026
pythongh-100538: Add workflow to verify bundled libexpat (pythonGH-14…
50cf282 
…5359)

Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Mar 2, 2026
[3.10] gh-100538: Add workflow to verify bundled libexpat (GH-145359) (…
dad6f8d 
…#145407)

gh-100538: Add workflow to verify bundled libexpat (GH-145359)

Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Mar 2, 2026
[3.11] gh-100538: Add workflow to verify bundled libexpat (GH-145359) (…
0557a1f 
…#145408)

gh-100538: Add workflow to verify bundled libexpat (GH-145359)

Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Mar 2, 2026
[3.12] gh-100538: Add workflow to verify bundled libexpat (GH-145359) (…
71bb5db 
…#145409)

gh-100538: Add workflow to verify bundled libexpat (GH-145359)

Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-100538: Add workflow to verify bundled libexpat (pythonGH-14…
ec3b68a 
…5359)

Add workflow to verify bundled libexpat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
hugovk Awaiting requested review from hugovk hugovk is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
webknjaz Awaiting requested review from webknjaz webknjaz is a code owner
+1 more reviewer
hartwork hartwork left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL