FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-89381: Fix invalid signatures of math/cmath.log by skirpichev · Pull Request #101070 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-89381: Fix invalid signatures of math/cmath.log - #101070

Closed
skirpichev wants to merge 1 commit into
python:mainfrom
skirpichev:fix-89381
ConversationCommits (1)ChecksFiles changed
Closed

gh-89381: Fix invalid signatures of math/cmath.log#101070
skirpichev wants to merge 1 commit into
python:mainfrom
skirpichev:fix-89381

Conversation

skirpichev commented Jan 16, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Jan 16, 2023
Open

hauntsaninja commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

Thanks for the PR! I was curious about why the existing code in mathmodule.c didn't work. It turns out that it is I think easy to fix, which led me to make an alternate PR here: #101115.

I think that PR is a slightly smaller change / closer to what whoever did the original argument clinic for mathmodule.c intended. But maybe c_default is sketchy or support for None is desirable, in which case this PR works too!

skirpichev mentioned this pull request Jan 18, 2023
Closed

skirpichev commented Jan 18, 2023

Copy link
Copy Markdown
Member Author

@hauntsaninja, thanks. I left few notes on the new PR.

skirpichev commented Jan 19, 2023

Copy link
Copy Markdown
Member Author

Closed per #101123

skirpichev closed this Jan 19, 2023
skirpichev deleted the fix-89381 branch January 19, 2023 07:48
mdickinson reviewed Jan 29, 2023
View reviewed changes
Comment thread Doc/library/cmath.rst
Returns the logarithm of *x* to the given *base*. If the *base* is not
specified, returns the natural logarithm of *x*. There is one branch cut, from 0
along the negative real axis to -∞, continuous from above.
specified or is None, returns the natural logarithm of *x*. There is one

mdickinson Jan 29, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In the interests of readability, I'd suggest reverting the change on this line - I think it's clear from context that "not specified" includes the case of deliberately specifying None.

skirpichev mentioned this pull request Jan 29, 2023
Merged

skirpichev commented Jan 29, 2023

Copy link
Copy Markdown
Member Author

reopened as #101404

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
mdickinson mdickinson left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL