FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-89381: Fix invalid signatures of math/cmath.log by skirpichev · Pull Request #101404 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-89381: Fix invalid signatures of math/cmath.log - #101404

Merged
hauntsaninja merged 3 commits into
python:mainfrom
skirpichev:fix-89381
Jan 29, 2023
ConversationCommits (3)ChecksFiles changed
Merged

gh-89381: Fix invalid signatures of math/cmath.log#101404
hauntsaninja merged 3 commits into
python:mainfrom
skirpichev:fix-89381

Conversation

skirpichev commented Jan 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Jan 29, 2023
Open
skirpichev mentioned this pull request Jan 29, 2023
Closed

skirpichev commented Jan 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Probably, changes in the math.rst could be reverted too (like 1efcf49 does) reworded like "If the base is not specified returns the natural logarithm (base e) of x.".

BTW, I would appreciate Raymond's review too.

mdickinson commented Jan 29, 2023

Copy link
Copy Markdown
Member

Yes, I'd suggest losing the or is None in the math.rst, too. Other than that, this LGTM.

mdickinson reviewed Jan 29, 2023
View reviewed changes
Comment thread Doc/library/math.rst Outdated
mdickinson approved these changes Jan 29, 2023
View reviewed changes

mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

skirpichev commented Jan 29, 2023

Copy link
Copy Markdown
Member Author

Thanks for review and I'm sorry for the closed pr.

hauntsaninja approved these changes Jan 29, 2023
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for sticking with this!

hauntsaninja merged commit 0ef92d9 into python:main Jan 29, 2023
skirpichev deleted the fix-89381 branch January 29, 2023 23:55
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
pythongh-89381: Fix invalid signatures of math/cmath.log (python#101404)
48d51e5
mdickinson added a commit to mdickinson/cpython that referenced this pull request Feb 5, 2023
Revert "pythongh-89381: Fix invalid signatures of math/cmath.log (pyt…
d1daa27 
…hon#101404)"

This reverts commit 0ef92d9.
mdickinson added a commit that referenced this pull request Feb 5, 2023
Revert "gh-89381: Fix invalid signatures of math/cmath.log (#101404)" (…
0672a6c 
…#101580)

This reverts commit 0ef92d9.
skirpichev added a commit to skirpichev/cpython that referenced this pull request Feb 6, 2023
pythongh-89381: Fix invalid signatures of math/cmath.log (python#101404)
5a8d031 
Restored 0ef92d9 after reversion in python#101580

skirpichev commented Feb 6, 2023

Copy link
Copy Markdown
Member Author

Restored in #101593

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hauntsaninja hauntsaninja approved these changes
+1 more reviewer
mdickinson mdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL