FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL by iritkatriel · Pull Request #101443 · python/cpython · GitHub

/ cpython Public

gh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL - #101443

Merged
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:rewrite_opcodes
Jan 31, 2023
ConversationCommits (5)ChecksFiles changed
Merged

gh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL#101443
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:rewrite_opcodes

Conversation

iritkatriel commented Jan 31, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Jan 31, 2023
Closed
gvanrossum reviewed Jan 31, 2023
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There might be leaks. :-(

Comment thread Python/bytecodes.c Outdated
Comment on lines +2328 to +2317
goto error;
ERROR_IF(true, error);

gvanrossum Jan 31, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I believe this leaks a reference to mgr. You can either insert another DECREF_INPUTS() before this line, or just keep the goto error. I prefer the latter, we're not going to require using DECREF_INPUTS() everywhere (it mostly exists because it would be useful with the register conversion).

iritkatriel Jan 31, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm was just looking at this. I added DECREF_INPUTS in these two places and it is still leaking something.

iritkatriel Jan 31, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I pushed the change with goto, still looking for the other leak.

Comment thread Python/bytecodes.c Outdated
Comment on lines +2340 to +2329
goto error;
ERROR_IF(true, error);

gvanrossum Jan 31, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same here.

iritkatriel commented Jan 31, 2023
View reviewed changes
Comment thread Python/generated_cases.c.h Outdated
goto error;
}
PUSH(res);
if (res == NULL) goto pop_1_error;

iritkatriel Jan 31, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's leaking when enter raises.

iritkatriel Jan 31, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It leaks exit. Before this PR it put exit in the stack before the 'goto error', but now it doesn't so it needs to decref exit.

iritkatriel changed the title gh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL gh-98831: rewrite GET_LEN, GET_ITER and a few simple opcodes in the instruction definition DSL Jan 31, 2023
iritkatriel added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 31, 2023

bedevere-bot commented Jan 31, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 2ee6241 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

2 similar comments

bedevere-bot commented Jan 31, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 2ee6241 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

bedevere-bot commented Jan 31, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 2ee6241 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

bedevere-bot removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 31, 2023
iritkatriel changed the title gh-98831: rewrite GET_LEN, GET_ITER and a few simple opcodes in the instruction definition DSL gh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL Jan 31, 2023
iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 31, 2023

bedevere-bot commented Jan 31, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit a925498 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 31, 2023
gvanrossum approved these changes Jan 31, 2023
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That LGTM, but there's still something that claims to leak -- importlib, no less. Let me re-run that build.

gvanrossum commented Jan 31, 2023

Copy link
Copy Markdown
Member

The PPC64 buildbots are simply out of disk space. (I think it may be the same machine.)

iritkatriel merged commit 29a858b into python:main Jan 31, 2023
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simp…
cc9952d 
…le opcodes in the instruction definition DSL (python#101443)
carljm added a commit to carljm/cpython that referenced this pull request Jan 31, 2023
Merge branch 'main' into inlinecomp2
ed3209b 
* main:
  pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)
  pythongh-99276 - Updated Doc/faq/general.rst (python#101396)
  Add JOBS parameter to docs Makefile (python#101395)
  pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)
  pythongh-77607: Improve accuracy of os.path.join docs (python#101406)
  Fixes typo in asyncio.TaskGroup context manager code example (python#101449)
  pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)
  pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
iritkatriel deleted the rewrite_opcodes branch April 3, 2023 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
brandtbucher Awaiting requested review from brandtbucher

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL