Fixes typo in asyncio.TaskGroup context manager code example - #101449
Merged
gvanrossum merged 1 commit intoJan 31, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
bcla22
requested review from
1st1,
asvetlov,
gvanrossum and
kumaraditya303
as code owners
January 31, 2023 04:00
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
gvanrossum
approved these changes
Jan 31, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good catch, and this is sufficiently semantically subtle that it is worth fixing. Thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @bcla22 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-101450 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 31, 2023
miss-islington
added a commit
that referenced
this pull request
Jan 31, 2023
(cherry picked from commit ef09bf6) Co-authored-by: Ben <22038077+bcla22@users.noreply.github.com>
mdboom
pushed a commit
to mdboom/cpython
that referenced
this pull request
Jan 31, 2023
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Jan 31, 2023
* main: pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439) pythongh-99276 - Updated Doc/faq/general.rst (python#101396) Add JOBS parameter to docs Makefile (python#101395) pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443) pythongh-77607: Improve accuracy of os.path.join docs (python#101406) Fixes typo in asyncio.TaskGroup context manager code example (python#101449) pythongh-98831: Clean up and add cache size static_assert to macro (python#101442) pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the docs, an example using an asyncio.TaskGroup context manager to create two tasks and execute them concurrently has a comment which reads "The wait is implicit when the context manager exits.". Likely this is meant to read "The await is implicit when the context manager exits".