GH-90997: Shrink the LOAD_GLOBAL caches - #102569
Merged
brandtbucher merged 9 commits intoMar 11, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks good. We will need to change the versioning scheme to reduce the chance of the version number reaching 2**16, but it is reasonable to do this first. |
Sorry, something went wrong.
markshannon
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing too clever here, just using 16 bits for module versions instead of 32. LOAD_GLOBAL still has no failures after this change.
Benchmarks came back very slightly negative, but I believe that's just noise (the results are being pulled down by several benchmarks known for their instability).