Repository navigation
Inline bytecode caches #90997
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/brandtbucher'
closed_at = None
created_at = <Date 2022-02-24.02:17:14.449>
labels = ['interpreter-core', 'deferred-blocker', '3.11', 'performance']
title = 'Inline bytecode caches'
updated_at = <Date 2022-04-01.11:29:28.677>
user = 'https://github.com/brandtbucher'bugs.python.org fields:
activity = <Date 2022-04-01.11:29:28.677>
actor = 'Mark.Shannon'
assignee = 'brandtbucher'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2022-02-24.02:17:14.449>
creator = 'brandtbucher'
dependencies = []
files = []
hgrepos = []
issue_num = 46841
keywords = ['patch']
message_count = 29.0
messages = ['413875', '413901', '413987', '413988', '414188', '414194', '414261', '414277', '414343', '414349', '414358', '414359', '414364', '414371', '414372', '414378', '414391', '414461', '414490', '414523', '414547', '414696', '414763', '414955', '415307', '415676', '415969', '416482', '416483']
nosy_count = 7.0
nosy_names = ['Mark.Shannon', 'corona10', 'pablogsal', 'brandtbucher', 'neonene', 'iritkatriel', 'penguin_wwy']
pr_nums = ['31543', '31552', '31575', '31591', '31618', '31622', '31640', '31663', '31664', '31671', '31709', '31742', '31780', '31817', '31888', '31901', '31968', '32099', '32100', '32205', '32222']
priority = 'deferred blocker'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue46841'
versions = ['Python 3.11']
Activity
brandtbucher commented on Feb 24, 2022
...as discussed in faster-cpython/ideas#263.
My plan is for this initial PR to lay the groundwork, then to work on porting over the existing opcode caches one-by-one. Once that's done, we can clean up lots of the "old" machinery.
markshannon commented on Feb 24, 2022
We need to decide what to do about dis.
I don't think we should have a show_cache option, as the caches are meaningless junk without quickening (maybe we should drop the CACHE opcode, and just use zeroes).
Instead we should have a show_quickened option, to show the quickened form, which we need to make clear is very much implementation defined.
E.g. Cinder might show the machine code as well.
That way, we can present the cache information as extra data on the quickened form, rather than junk instructions.
markshannon commented on Feb 25, 2022
New changeset 0f41aac by Brandt Bucher in branch 'main':
bpo-46841: Use inline caching for BINARY_OP (GH-31543)
0f41aac
markshannon commented on Feb 25, 2022
Making this a release blocker, as we really cannot leave this half finished for the release.
Shouldn't be a problem, as we'll have it done in a week or so.
markshannon commented on Feb 28, 2022
New changeset 424ecab by Brandt Bucher in branch 'main':
bpo-46841: Use inline caching for UNPACK_SEQUENCE (GH-31591)
424ecab
35 remaining items
GH-90997: Document CACHEs (GH-95694)
pythonGH-90997: Document CACHEs (pythonGH-95694)
GH-90997: Document CACHEs (GH-95694) (GH-95696)
pythonGH-90997: Document CACHEs (pythonGH-95694)
GH-90997: Wrap yield from/await in a virtual try/except StopIteration (…
iritkatriel commented on Sep 7, 2022
Is there anything left to do here?
markshannon commented on Sep 7, 2022
No. This is done.
GH-90997: Improve inline cache performance for MSVC (GH-96781)
GH-90997: Shrink the LOAD_GLOBAL caches (#102569)
pythonGH-90997: Shrink the LOAD_GLOBAL caches (python#102569)