| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 26d0d70 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
Performance is underwhelming. What is notable is that the number of EXTENDED_ARG instructions more than doubles from ~0.3% to ~0.7%. |
Sorry, something went wrong.
Yeah, I suspect we may not see a ton of payoff until we convert most/all of the caches. |
Sorry, something went wrong.
There was a problem hiding this comment.
A few things:
Sorry, something went wrong.
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
👍
Hmm, I'd prefer not. Versions, for example, are 32 bit value, not 2 code units. If the size of the _Py_CODEUNIT were to change, we would still want versions to be 32 bit numbers. Maybe we should give up on the pretense that the size of the code unit can be easily changed, and replace _Py_CODEUNIT with the standard type uint16_t? |
Sorry, something went wrong.
| # Python 3.11a5 3481 (Use inline CACHE instructions) | ||
| # Python 3.11a5 3482 (Use inline caching for UNPACK_SEQUENCE) | ||
| # Python 3.11a5 3481 (Use inline cache for BINARY_OP) | ||
| # Python 3.11a5 3482 (Use inline caching for UNPACK_SEQUENCE and LOAD_GLOBAL) |
There was a problem hiding this comment.
Hm, looks like the magic number wasn't actually changed... bad merge?
Sorry, something went wrong.
There was a problem hiding this comment.
I figured we didn't need more than one version number per day.
Sorry, something went wrong.
There was a problem hiding this comment.
#31618 has another version number bump.
Sorry, something went wrong.
There was a problem hiding this comment.
Ah, I see what you did now. Thanks for clarifying.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Also removes duplication of the _PyOpcode_InlineCacheEntries table.
https://bugs.python.org/issue46841