bpo-46841: Fix BINARY_OP's handling of inline caches - #31671
Merged
brandtbucher merged 2 commits intoMar 4, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
26 tasks
Copy link
Copy Markdown
Member
|
Changes LGTM. OOI, how did you find this? Would it be feasible to add a regression test? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
After the LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE issue on #31640, I went through both these files and reviewed our use of instruction pointers. #31664 came out of that too.
Not until we can dis quickened code. Once that happens, I can go through and add a new suite of test cases for all of our adaptive/specialized/super instructions. Don't worry, it will be less like test_dis.py and more like test_peepholer.py. ;) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46841