GH-63062: Implement __subclasshook__() for Finders and Loaders in abc lib - #102763
Closed
furkanonder wants to merge 4 commits into
Closed
GH-63062: Implement __subclasshook__() for Finders and Loaders in abc lib#102763furkanonder wants to merge 4 commits into
furkanonder wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Member
|
FYI there's a merge conflict. |
Sorry, something went wrong.
brettcannon
removed their request for review
June 9, 2023 22:29
Copy link
Copy Markdown
Member
|
To keep my review queue clean, I'm removing myself to review until the merge conflict is fixed. Feel free to add me back once the conflict is fixed. |
Sorry, something went wrong.
furkanonder
requested review from
brettcannon,
ncoghlan and
warsaw
as code owners
June 10, 2023 20:45
Copy link
Copy Markdown
Contributor
Author
|
This PR seems to deprecate find_loader and find_module. For this reason I think it makes sense to close the PR. @brettcannon What do you think? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@furkanonder it's your PR so if you think it should be closed I'm fine with that. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.