FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98040: Remove find_loader, find_module and other deprecated APIs by warsaw · Pull Request #98059 · python/cpython · GitHub

/ cpython Public

gh-98040: Remove find_loader, find_module and other deprecated APIs - #98059

Merged
warsaw merged 39 commits into
python:mainfrom
warsaw:find_loader
May 3, 2023
ConversationCommits (39)ChecksFiles changed
Merged

gh-98040: Remove find_loader, find_module and other deprecated APIs#98059
warsaw merged 39 commits into
python:mainfrom
warsaw:find_loader

Conversation

warsaw commented Oct 7, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

warsaw commented Oct 7, 2022

Copy link
Copy Markdown
Member Author

Still lots of test failures and probably more things to remove, but it's a start!

warsaw marked this pull request as ready for review October 7, 2022 23:14

warsaw commented Oct 7, 2022

Copy link
Copy Markdown
Member Author

@brettcannon @ericsnowcurrently Well, this branch is already getting pretty big. Pull a thread, unravel a sweater. There's still some things to do (see the ticket), but it's not too late to provide feedback. I was pretty aggressive in removing things that seemed to be obsolete or testing obsolete APIs, so hopefully I wasn't too eager to remove things. Feedback welcome!

warsaw requested a review from vsajip as a code owner October 9, 2022 22:54

brettcannon commented Oct 14, 2022

Copy link
Copy Markdown
Member

Should this PR be a draft until the tests are passing?

warsaw marked this pull request as draft October 15, 2022 19:28

warsaw commented Oct 15, 2022

Copy link
Copy Markdown
Member Author

Should this PR be a draft until the tests are passing?

Yes, done. The blocker is being worked on upstream so I think pip 23.0 will likely unblock this PR. In the meantime, I'll keep the branch clean as is.

AA-Turner reviewed Apr 29, 2023
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There's quite a few places in the docs where we need to update cross references as of this PR (mainly pre-fixing with an !) -- though as they're on lines too far from the changes I can't do inline suggestions.

Would you be happy for me to push to this branch with said docs cross-referencing changes?

A

Comment thread Doc/library/importlib.rst

warsaw commented May 1, 2023

Copy link
Copy Markdown
Member Author

Would you be happy for me to push to this branch with said docs cross-referencing changes?

Yes, this would be very helpful, thanks.

warsaw self-assigned this May 1, 2023

AA-Turner commented May 2, 2023

Copy link
Copy Markdown
Member

Yes, this would be very helpful, thanks.

Done, thank you!

A

warsaw commented May 2, 2023

Copy link
Copy Markdown
Member Author

Done, thank you!

Thank you!

warsaw requested a review from Yhg1s May 2, 2023 20:33
warsaw merged commit 3269978 into python:main May 3, 2023
warsaw deleted the find_loader branch May 3, 2023 11:55
erlend-aasland mentioned this pull request May 3, 2023
Merged
jaraco pushed a commit to python/importlib_metadata that referenced this pull request Jun 7, 2023
gh-98040: Backport python/cpython#98059
cc17826 
Removed ``fixtures.NullFinder``.

---------

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
jaraco pushed a commit to python/importlib_metadata that referenced this pull request Jun 8, 2023
gh-98040: Backport python/cpython#98059
70a6075 
Removed ``fixtures.NullFinder``.

---------

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
furkanonder mentioned this pull request Jun 10, 2023
Closed
clrpackages pushed a commit to clearlinux-pkgs/pypi-importlib_metadata that referenced this pull request Jun 20, 2023
pypi-importlib_metadata: Autospec creation for update from version 6.…
1de6fa2 
…6.0 to version 6.7.0

Barry Warsaw (1):
      gh-98040: Backport python/cpython#98059

Jason R. Coombs (21):
      Remove unnecessary and incorrect copyright notice. Fixes jaraco/skeleton#78.
      Replace flake8 with ruff. Fixes jaraco/skeleton#79 and sheds debt.
      👹 Feed the hobgoblins (delint).
      Make substitution fields more prominent and distinct from true 'skeleton' references. (#71)
      Suppress EncodingWarning in build.env. Ref pypa/build#615.
      Remove reference to EncodingWarning as it doesn't exist on some Pythons.
      Inline the NullFinder behavior.
      Add docstring to test_integration to give some context.
      Remove Python 2 compatibility in _compat.NullFinder.
      Move test_interleaved_discovery from test_integration to test_main.
      Remove test_search_dist_dirs as it was never used. Ref python/importlib_metadata#111.
      Extract _topmost and _get_toplevel_name functions.
      Extract _topmost and _get_toplevel_name functions.
      Capture that _get_toplevel_name can return None.
      Streamline the test to check one expectation (the standard dist-info expectation is handled by other tests above.
      Inline the symlink setup.
      Consolidate PackageDistributions tests.
      Update _path to jaraco.path 3.6 with symlink support.
      Utilize the new Symlink in preparing the test case.
      Update changelog.
      Remove '__init__.py', not needed.

Johan Herland (2):
      Add test to demonstrate issue with symlinked packages
      Attempt to fix issue with symlinked packages
Ghost-LZW mentioned this pull request May 15, 2024
Closed
fumoboy007 added a commit to fumoboy007/intellij-community that referenced this pull request Sep 16, 2024
Implement MetaPathFinder.find_spec method in MyFinder subclass.
e97431c 
The `MyFinder` subclass of [`MetaPathFinder`](https://docs.python.org/3.11/library/importlib.html#importlib.abc.MetaPathFinder) currently only implements the deprecated `find_module` method. That deprecated method was [removed](python/cpython#98059) in Python 3.12. This change adds an implementation for its replacement method called `find_spec`.
fumoboy007 mentioned this pull request Sep 16, 2024
Closed
fumoboy007 added a commit to fumoboy007/intellij-community that referenced this pull request Sep 16, 2024
Update six.py to version 1.16.0.
b336305 
The included `six.py` is from version 1.9.0. This version is not compatible with Python 3.12, which [removed](python/cpython#98059) the deprecated `MetaPathFinder.find_module` method. This change updates `six.py` to version [1.16.0](https://github.com/benjaminp/six/blob/65486e4383f9f411da95937451205d3c7b61b9e1/six.py), which uses the replacement `MetaPathFinder.find_spec` method.
fumoboy007 mentioned this pull request Sep 16, 2024
Closed
tungol mentioned this pull request Dec 16, 2024
Open
intellij-monorepo-bot pushed a commit to JetBrains/intellij-community that referenced this pull request Jul 10, 2025
Implement MetaPathFinder.find_spec method in MyFinder subclass.
12cfd48 
The `MyFinder` subclass of [`MetaPathFinder`](https://docs.python.org/3.11/library/importlib.html#importlib.abc.MetaPathFinder) currently only implements the deprecated `find_module` method. That deprecated method was [removed](python/cpython#98059) in Python 3.12. This change adds an implementation for its replacement method called `find_spec`.

closes #2847

GitOrigin-RevId: b7ebb9f36ac87389298df14f0672ec037da004ef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

arhadthedev arhadthedev left review comments
AA-Turner AA-Turner left review comments
Yhg1s Yhg1s approved these changes
vsajip Awaiting requested review from vsajip
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
encukou Awaiting requested review from encukou
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

Assignees

warsaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL