Repository navigation
gh-48330: assert warning is emitted on unittest.TestResult with no addDuration - #103309
Merged
iritkatriel merged 1 commit intoApr 6, 2023
Merged
iritkatriel merged 1 commit into
iritkatriel merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks. LGTM. |
Sorry, something went wrong.
giampaolo
approved these changes
Apr 6, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
hrnciar
pushed a commit
to fedora-python/cpython
that referenced
this pull request
Apr 12, 2023
…lt with no addDuration (python#103309)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the warning below, which started with #12271.
====================================================================== ERROR: test_run_call_order_default_result (test.test_unittest.test_case.Test_TestCase.test_run_call_order_default_result) ---------------------------------------------------------------------- AttributeError: 'ResultWithNoStartTestRunStopTestRun' object has no attribute 'addDuration' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/Users/iritkatriel/src/cpython/Lib/test/test_unittest/test_case.py", line 307, in test_run_call_order_default_result Foo('test').run() File "/Users/iritkatriel/src/cpython/Lib/unittest/case.py", line 639, in run self._addDuration(result, (time.perf_counter() - start_time)) File "/Users/iritkatriel/src/cpython/Lib/unittest/case.py", line 580, in _addDuration warnings.warn("TestResult has no addDuration method", RuntimeWarning: TestResult has no addDuration method