FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-4080: unittest durations by giampaolo · Pull Request #12271 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-4080: unittest durations - #12271

Merged
giampaolo merged 50 commits into
python:mainfrom
giampaolo:unittest-durations
Apr 2, 2023
ConversationCommits (50)ChecksFiles changed
Merged

bpo-4080: unittest durations#12271
giampaolo merged 50 commits into
python:mainfrom
giampaolo:unittest-durations

Conversation

giampaolo commented Mar 11, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Adds cmdline option to show unit-tests durations + summary of the slowest ones, see https://bugs.python.org/issue4080.

Top 5 slowest ones:

$ ./python -m unittest Lib.test.test_ftplib --durations=5 
..........................................s.............................................
Slowest test durations
----------------------------------------------------------------------
0.203s     test_with_statement (Lib.test.test_ftplib.TestFTPClass)
0.204s     test_retrbinary_rest (Lib.test.test_ftplib.TestTLS_FTPClassMixin)
0.214s     test_with_statement (Lib.test.test_ftplib.TestTLS_FTPClassMixin)
0.881s     test_mlsd (Lib.test.test_ftplib.TestFTPClass)
1.162s     test_mlsd (Lib.test.test_ftplib.TestTLS_FTPClassMixin)

----------------------------------------------------------------------
Ran 88 tests in 5.264s

OK (skipped=1)

All + individual elapsed time:

$ ./python -m unittest Lib.test.test_ftplib --durations=0 -v
test_abort (Lib.test.test_ftplib.TestFTPClass) ... [0.002s] ok
test_all_errors (Lib.test.test_ftplib.TestFTPClass) ... [0.001s] ok
test_cwd (Lib.test.test_ftplib.TestFTPClass) ... [0.001s] ok
test_delete (Lib.test.test_ftplib.TestFTPClass) ... [0.001s] ok
test_dir (Lib.test.test_ftplib.TestFTPClass) ... [0.041s] ok
test_mlsd (Lib.test.test_ftplib.TestFTPClass) ... [0.880s] ok
test_nlst (Lib.test.test_ftplib.TestFTPClass) ... [0.092s] ok
test_parse257 (Lib.test.test_ftplib.TestFTPClass) ... [0.002s] ok
...

Slowest test durations
----------------------------------------------------------------------
0.000s     test__all__ (Lib.test.test_ftplib.MiscTestCase)
0.002s     test_pwd (Lib.test.test_ftplib.TestFTPClass)
....
0.140s     test_storbinary_rest (Lib.test.test_ftplib.TestTLS_FTPClassMixin)
0.148s     test_data_connection (Lib.test.test_ftplib.TestTLS_FTPClass)
0.154s     test_storlines (Lib.test.test_ftplib.TestTLS_FTPClassMixin)
0.175s     test_retrbinary_rest (Lib.test.test_ftplib.TestTLS_FTPClassMixin)
0.204s     test_with_statement (Lib.test.test_ftplib.TestFTPClass)
0.208s     test_with_statement (Lib.test.test_ftplib.TestTLS_FTPClassMixin)
0.880s     test_mlsd (Lib.test.test_ftplib.TestFTPClass)
1.281s     test_mlsd (Lib.test.test_ftplib.TestTLS_FTPClassMixin)

----------------------------------------------------------------------
Ran 88 tests in 5.396s

OK (skipped=1)

https://bugs.python.org/issue4080

giampaolo added 21 commits March 10, 2019 04:58
tirkarthi reviewed Apr 25, 2019
View reviewed changes
Comment thread Lib/unittest/runner.py Outdated
tirkarthi reviewed Apr 25, 2019
View reviewed changes
Comment thread Doc/library/unittest.rst
tirkarthi reviewed Apr 26, 2019
View reviewed changes
Comment thread Doc/library/unittest.rst Outdated

giampaolo commented Nov 24, 2022

Copy link
Copy Markdown
Contributor Author

Hi @iritkatriel and thanks for taking a look at this. I have merged all test conflicts and polished the implementation a little, since the PR was 3 years and unittest code changed in the meantime.

ezio-melotti reviewed Nov 28, 2022
View reviewed changes
Comment thread Lib/unittest/runner.py Outdated
Comment thread Misc/NEWS.d/next/Library/2022-11-24-13-23-07.gh-issue-48330.6uAX9F.rst Outdated

giampaolo commented Apr 2, 2023

Copy link
Copy Markdown
Contributor Author

@LiteApplication thanks for approving. Merging.

eggplants commented Apr 2, 2023

Copy link
Copy Markdown

@giampaolo @LiteApplication doesn't appear to be a regular Python reviewer, is it no problem to merge?

This comment was marked as off-topic.

Sign in to view

terryjreedy commented Apr 3, 2023

Copy link
Copy Markdown
Member

Hidden buildbot failure was for test_asyncio. I presume unrelated since random test_asyncio failures are unfortunately routine.

gpshead reviewed Apr 3, 2023
View reviewed changes
Comment thread Doc/library/unittest.rst
Comment thread Lib/test/test_unittest/test_runner.py
Comment thread Lib/unittest/result.py
giampaolo mentioned this pull request Apr 3, 2023
Merged

giampaolo commented Apr 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I created #103209 to address @gpshead's post-merge comments to this PR.

giampaolo commented Apr 3, 2023

Copy link
Copy Markdown
Contributor Author

@eggplants wrote:

@giampaolo @LiteApplication doesn't appear to be a regular Python reviewer, is it no problem to merge?

Sorry, I didn't realize that. This was an old PR that unfortunately never received much attention, so it stayed idle for a long time and I occasionally updated it to fix merge conflicts. When I finally saw an approval I was just happy to see it and merged it without further checking. FWIW, I went through these changes multiple times over the last 4 years: I'm confident that the changes introduced in here are OK and are fully retro compatible (this probably was the most sensitive part to consider).

eggplants commented Apr 3, 2023

Copy link
Copy Markdown

Anyway, I am glad this feature has finally been merged. Thank you @giampaolo -san.

iritkatriel mentioned this pull request Apr 6, 2023
Merged
masklinn mentioned this pull request Apr 6, 2023
Closed
giampaolo mentioned this pull request Apr 20, 2023
Closed

giampaolo commented Apr 26, 2023

Copy link
Copy Markdown
Contributor Author

Here's a nose issue related to this PR's retro-compatibility: nose-devs/nose2#569.
nose extended TestCase class without defining the new addDuration method. Python 3.12 emitted a warning but it didn't crash.

bityob mentioned this pull request Jul 14, 2023
Open
Eclips4 mentioned this pull request Aug 12, 2023
Open
adiroiban mentioned this pull request Dec 19, 2023
Merged
This was referenced Sep 2, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead left review comments
Fidget-Spinner Awaiting requested review from Fidget-Spinner
iritkatriel Awaiting requested review from iritkatriel
tirkarthi Awaiting requested review from tirkarthi
ezio-melotti Awaiting requested review from ezio-melotti
+1 more reviewer
LiteApplication LiteApplication approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL