| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thanks for getting to this sooner than I did! |
Sorry, something went wrong.
|
I was basing it on this 3.11 PR, I know better than using master branch for this. But yes, I will re-check, that everything in that PR has been included. |
Sorry, something went wrong.
|
Ah, sorry! I just looked at the versionchanged:: 3.12 and gave a quick comment. Will do a proper review later. |
Sorry, something went wrong.
…et the sticky bit (pythonGH-103831) Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is enough. Backport of c8c3956
|
Yes, you were right, I missed those, not sure how I have managed to do that. |
Sorry, something went wrong.
|
I don't understand those Windows failures … shouldn’t it be covered by ae62b3a ? |
Sorry, something went wrong.
|
No. ae62b3a is for Solaris or BSD, supported platforms (per PEP 11) don't need it. This change made me get a Windows VM, so I'll investigate there. Can't promise it'll be this week though. |
Sorry, something went wrong.
|
It's related to a change made while backporting, going from if mode is not None and os_helper.can_chmod():to just if mode is not None:The can_chmod() determines whether chmod can set all the mode bits. According to the docs, it's only limited on Windows, so I'll hardcode that. (It's also limited on WASI, but in 3.10 tests we don't care.) I can't push fixes to your repo so I opened #104327. |
Sorry, something went wrong.
Sorry about that, I don’t know how to set it up with the existing PR. |
Sorry, something went wrong.
|
Couldn’t you just make PR to https://github.com/openSUSE-Python/cpython/tree/PEP706-for-py310 ? |
Sorry, something went wrong.
|
I don't think I could run CPython buildbots on another repo. |
Sorry, something went wrong.
|
The red checks are unrelated: Python 3.10 doesn't build on Wasm, and RtD's OpenSSL is too old for urllib3. |
Sorry, something went wrong.
|
Thanks for the backport! |
Sorry, something went wrong.
|
So, now 3.9! :) |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Manual port of gh-102953 to 3.10.
Please, review.