FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.10] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953) by mcepl · Pull Request #104128 · python/cpython · GitHub

/ cpython Public

[3.10] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953) - #104128

Merged
encukou merged 7 commits into
python:3.10from
openSUSE-Python:PEP706-for-py310
May 10, 2023
Merged

[3.10] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953)#104128
encukou merged 7 commits into
python:3.10from
openSUSE-Python:PEP706-for-py310

Conversation

mcepl commented May 3, 2023
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Manual port of gh-102953 to 3.10.

Please, review.

encukou commented May 3, 2023

Copy link
Copy Markdown
Member

Thanks for getting to this sooner than I did!
But see https://github.com/python/cpython/pull/103832/commits for the changes needed in the backport.

mcepl commented May 3, 2023

Copy link
Copy Markdown
Contributor Author

I was basing it on this 3.11 PR, I know better than using master branch for this. But yes, I will re-check, that everything in that PR has been included.

encukou commented May 3, 2023

Copy link
Copy Markdown
Member

Ah, sorry! I just looked at the versionchanged:: 3.12 and gave a quick comment. Will do a proper review later.

mcepl commented May 3, 2023

Copy link
Copy Markdown
Contributor Author

Yes, you were right, I missed those, not sure how I have managed to do that.

mcepl commented May 3, 2023

Copy link
Copy Markdown
Contributor Author

I don't understand those Windows failures … shouldn’t it be covered by ae62b3a ?

Comment thread Doc/library/shutil.rst Outdated

encukou commented May 4, 2023
edited
Loading

Copy link
Copy Markdown
Member

No. ae62b3a is for Solaris or BSD, supported platforms (per PEP 11) don't need it.

This change made me get a Windows VM, so I'll investigate there. Can't promise it'll be this week though.

encukou commented May 9, 2023

Copy link
Copy Markdown
Member

It's related to a change made while backporting, going from

        if mode is not None and os_helper.can_chmod():

to just

        if mode is not None:

The can_chmod() determines whether chmod can set all the mode bits. According to the docs, it's only limited on Windows, so I'll hardcode that. (It's also limited on WASI, but in 3.10 tests we don't care.)

I can't push fixes to your repo so I opened #104327.

mcepl commented May 9, 2023

Copy link
Copy Markdown
Contributor Author

I can't push fixes to your repo so I opened #104327.

Sorry about that, I don’t know how to set it up with the existing PR.

encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 9, 2023

mcepl commented May 9, 2023

Copy link
Copy Markdown
Contributor Author

Couldn’t you just make PR to https://github.com/openSUSE-Python/cpython/tree/PEP706-for-py310 ?

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 7ab6233 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 9, 2023

encukou commented May 9, 2023

Copy link
Copy Markdown
Member

I don't think I could run CPython buildbots on another repo.
But since you've updated this PR quickly, I'll run them here.

encukou commented May 10, 2023

Copy link
Copy Markdown
Member

The red checks are unrelated: Python 3.10 doesn't build on Wasm, and RtD's OpenSSL is too old for urllib3.

encukou merged commit 425065b into python:3.10 May 10, 2023

encukou commented May 10, 2023

Copy link
Copy Markdown
Member

Thanks for the backport!

mcepl deleted the PEP706-for-py310 branch May 10, 2023 12:27

mcepl commented May 10, 2023

Copy link
Copy Markdown
Contributor Author

So, now 3.9! :)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL