FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-97950: Use new-style index directive ('statement') by AA-Turner · Pull Request #104162 · python/cpython · GitHub

/ cpython Public

GH-97950: Use new-style index directive ('statement') - #104162

Merged
hugovk merged 4 commits into
python:mainfrom
AA-Turner:old-index-directives/statement
May 4, 2023
ConversationCommits (4)ChecksFiles changed
Merged

GH-97950: Use new-style index directive ('statement')#104162
hugovk merged 4 commits into
python:mainfrom
AA-Turner:old-index-directives/statement

Conversation

AA-Turner commented May 4, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request May 4, 2023
Closed
AA-Turner self-assigned this May 4, 2023
AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes labels May 4, 2023
ezio-melotti approved these changes May 4, 2023
View reviewed changes
Comment thread Doc/reference/simple_stmts.rst
! statement: break
statement: for
statement: while
! pair: statement; break

ezio-melotti May 4, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What does the ! do?

AA-Turner May 4, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-index

You can mark up “main” index entries by prefixing them with an exclamation mark. The references to “main” entries are emphasized in the generated index. For example, if two pages contain

A little hard to discover, unfortunately.

hugovk merged commit 55d50d1 into python:main May 4, 2023

miss-islington commented May 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented May 4, 2023

Copy link
Copy Markdown
Contributor

Sorry @AA-Turner and @hugovk, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 55d50d147c953fab37b273bca9ab010f40e067d3 3.11

miss-islington assigned hugovk and unassigned AA-Turner May 4, 2023
hugovk added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 4, 2023

miss-islington commented May 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot commented May 4, 2023

Copy link
Copy Markdown

GH-104163 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label May 4, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 4, 2023
pythonGH-97950: Use new-style index directive ('statement') (pythonGH…
cb7222d 
…-104162)

(cherry picked from commit 55d50d1)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

hugovk commented May 4, 2023

Copy link
Copy Markdown
Member

Momentary backport confusion from merging this before the previous backport was merged. All good for the second attempt 🚀

hugovk pushed a commit that referenced this pull request May 4, 2023
[3.11] GH-97950: Use new-style index directive ('statement') (GH-104162…
6a970ae 
…) (#104163)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
mattwang44 mentioned this pull request Jul 25, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
ezio-melotti ezio-melotti approved these changes
CAM-Gerlach Awaiting requested review from CAM-Gerlach

Assignees

hugovk

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL