FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] GH-97950: Fix old-style index directive in Doc/library/imp.rst by mattwang44 · Pull Request #107246 · python/cpython · GitHub

/ cpython Public

[3.11] GH-97950: Fix old-style index directive in Doc/library/imp.rst - #107246

Merged
hugovk merged 1 commit into
python:3.11from
mattwang44:old-index-directives-in-library-imp
Jul 26, 2023
ConversationCommits (1)ChecksFiles changed
Merged

[3.11] GH-97950: Fix old-style index directive in Doc/library/imp.rst#107246
hugovk merged 1 commit into
python:3.11from
mattwang44:old-index-directives-in-library-imp

Conversation

mattwang44 commented Jul 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

I found the following message when building 3.11 doc:

Warning, treated as error:
'statement' is deprecated for index entries (from entry 'statement: import'). Use 'pair: statement; import' instead.

It's part of sphinx-doc/sphinx#11412 and was released with sphinx 7.1.0 yesterday.

@AA-Turner resolved most issues in #104162 (and its 3.11 backport PR is #104163). However, imp module was removed in 3.12 before that and the old index directive in library/imp.rst seems to be omitted.

📚 Documentation preview 📚: https://cpython-previews--107246.org.readthedocs.build/

bedevere-bot mentioned this pull request Jul 25, 2023
Closed
bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 25, 2023
mattwang44 force-pushed the old-index-directives-in-library-imp branch from d1f419e to 9158f63 Compare July 25, 2023 14:15
mattwang44 changed the title GH-97950: Use new-style index directive (Doc/library/imp.rst@3.11) GH-97950: Use new-style index directive in Doc/library/imp.rst@3.11 Jul 25, 2023
mattwang44 changed the title GH-97950: Use new-style index directive in Doc/library/imp.rst@3.11 [3.11] GH-97950: Use new-style index directive in Doc/library/imp.rst Jul 25, 2023
mattwang44 changed the title [3.11] GH-97950: Use new-style index directive in Doc/library/imp.rst [3.11] GH-97950: Fix old-style index directive in Doc/library/imp.rst Jul 25, 2023
mattwang44 force-pushed the old-index-directives-in-library-imp branch from 9158f63 to 7c3d6ae Compare July 26, 2023 02:26

AA-Turner commented Jul 26, 2023

Copy link
Copy Markdown
Member

cc: @hugovk @ezio-melotti

hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 26, 2023
hugovk approved these changes Jul 26, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

hugovk merged commit 9fa44d7 into python:3.11 Jul 26, 2023

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @mattwang44 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Sorry, @mattwang44 and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9fa44d7a3045f4571e2cabd53a1cc0f16a0f3723 3.12

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Sorry, @mattwang44 and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9fa44d7a3045f4571e2cabd53a1cc0f16a0f3723 3.11

hugovk commented Jul 26, 2023

Copy link
Copy Markdown
Member

Ignore those two Miss Islington messages, this obviously doesn't need back porting to 3.12 and 3.11 branches because this went straight to 3.11 only.

Thanks again!

hugovk removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 26, 2023
hugovk removed their assignment Jul 26, 2023
mattwang44 deleted the old-index-directives-in-library-imp branch July 26, 2023 06:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
AA-Turner AA-Turner approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL