FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101282: Revert some M4 style for BOLT configuration by corona10 · Pull Request #104751 · python/cpython · GitHub

/ cpython Public

gh-101282: Revert some M4 style for BOLT configuration - #104751

Closed
corona10 wants to merge 4 commits into
python:mainfrom
corona10:gh-101282-fix-macos
ConversationCommits (4)ChecksFiles changed
Closed

gh-101282: Revert some M4 style for BOLT configuration#104751
corona10 wants to merge 4 commits into
python:mainfrom
corona10:gh-101282-fix-macos

Conversation

corona10 commented May 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Without this revert on macOS:

checking for --enable-bolt... no
checking BOLT_INSTRUMENT_FLAGS...
checking BOLT_APPLY_FLAGS... ./configure: line 8401: -reorder-blocks=ext-tsp: command not found

With this revert on macOS:

checking BOLT_INSTRUMENT_FLAGS...
checking BOLT_APPLY_FLAGS... -update-debug-sections -reorder-blocks=ext-tsp -reorder-functions=hfsort+ -split-functions -icf=1 -inline-all -split-eh -reorder-functions-use-hot-size -peepholes=none -jump-tables=aggressive -inline-ap -indirect-call-promotion=all -dyno-stats -use-gnu-stack -frame-opt=hot

corona10 requested a review from erlend-aasland as a code owner May 22, 2023 15:25
bedevere-bot mentioned this pull request May 22, 2023
Closed
4 tasks
corona10 requested a review from ned-deily May 22, 2023 15:33
ned-deily approved these changes May 22, 2023
View reviewed changes

ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

corona10 commented May 22, 2023

Copy link
Copy Markdown
Member Author

@ned-deily cc @erlend-aasland

I am preparing another PR too.

corona10 commented May 23, 2023

Copy link
Copy Markdown
Member Author

cc @indygreg Not decided yet which PR will be merged

corona10 added the needs backport to 3.12 only security fixes label May 23, 2023
erlend-aasland requested changes May 24, 2023
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If we go for this variant, I'd make the list more "git diff" friendly. I left a suggestion for this.

Comment thread configure.ac Outdated

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

erlend-aasland mentioned this pull request May 24, 2023
Merged
corona10 and others added 2 commits May 24, 2023 16:06
Update configure.ac
b2abdb3 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
regen
a5812a3
erlend-aasland approved these changes May 24, 2023
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but I prefer #104752

corona10 closed this May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ned-deily ned-deily approved these changes
erlend-aasland erlend-aasland approved these changes

Assignees

Yhg1s

erlend-aasland

Labels

awaiting merge needs backport to 3.12 only security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL