FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes by corona10 · Pull Request #104752 · python/cpython · GitHub

/ cpython Public

gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes - #104752

Merged
corona10 merged 2 commits into
python:mainfrom
corona10:gh-101282-fix-macos-other
May 24, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes#104752
corona10 merged 2 commits into
python:mainfrom
corona10:gh-101282-fix-macos-other

Conversation

corona10 commented May 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Without this revert on macOS:

checking for --enable-bolt... no
checking BOLT_INSTRUMENT_FLAGS...
checking BOLT_APPLY_FLAGS... ./configure: line 8401: -reorder-blocks=ext-tsp: command not found

With this revert on macOS:

checking BOLT_INSTRUMENT_FLAGS...
checking BOLT_APPLY_FLAGS... -update-debug-sections -reorder-blocks=ext-tsp -reorder-functions=hfsort+ -split-functions -icf=1 -inline-all -split-eh -reorder-functions-use-hot-size -peepholes=none -jump-tables=aggressive -inline-ap -indirect-call-promotion=all -dyno-stats -use-gnu-stack -frame-opt=hot

corona10 requested a review from ned-deily May 22, 2023 16:02
corona10 requested a review from erlend-aasland as a code owner May 22, 2023 16:02
bedevere-bot mentioned this pull request May 22, 2023
Closed
4 tasks

corona10 commented May 23, 2023

Copy link
Copy Markdown
Member Author

cc @indygreg Not decided yet which PR will be merged

corona10 added the needs backport to 3.12 only security fixes label May 23, 2023

erlend-aasland commented May 23, 2023

Copy link
Copy Markdown
Contributor

Dong-hee: I'll take a look tonight (CET).

corona10 mentioned this pull request May 23, 2023
Closed
erlend-aasland reviewed May 24, 2023
View reviewed changes
Comment thread configure.ac Outdated
erlend-aasland requested changes May 24, 2023
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://github.com/python/cpython/pull/104752/files#r1203531051

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

erlend-aasland changed the title gh-101282: Fix M4 style for BOLT configuration gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes May 24, 2023
erlend-aasland mentioned this pull request May 24, 2023
Closed

erlend-aasland commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks!

corona10 merged commit c437851 into python:main May 24, 2023

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Sorry @corona10, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker c43785192c97698a0217a680b30baae22106ed3e 3.12

miss-islington assigned corona10 and unassigned Yhg1s May 24, 2023
corona10 added a commit to corona10/cpython that referenced this pull request May 24, 2023
[3.12] pythongh-101282: Enclose BOLT_APPLY_FLAGS value in double quot…
36f5894 
…es (pythongh-104752)

(cherry picked from commit c437851)

Co-authored-by: Dong-hee Na <donghee.na@python.org>

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104853 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104853 is a backport of this pull request to the 3.12 branch.

erlend-aasland commented May 24, 2023

Copy link
Copy Markdown
Contributor

I forgot to ask the obvious question: did you verify that the warning disappeared?

corona10 added a commit that referenced this pull request May 24, 2023
[3.12] gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes (gh… (
b151660 
gh-104853)

[3.12] gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes (gh-104752)
(cherry picked from commit c437851)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
ned-deily Awaiting requested review from ned-deily

Assignees

corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL