FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104773: PEP 594: Remove the pipes module by vstinner · Pull Request #104848 · python/cpython · GitHub

Repository navigation

gh-104773: PEP 594: Remove the pipes module - #104848

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:remove_pipes
May 24, 2023
Merged

vstinner merged 2 commits into
python:mainfrom
vstinner:remove_pipes

Conversation

vstinner commented May 24, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

vstinner changed the title gh-104773: PEP 594: Remove pipes module gh-104773: PEP 594: Remove the pipes module May 24, 2023

hugovk commented May 24, 2023

Copy link
Copy Markdown
Member

The doctest failure is unrelated, here's a PR to fix it: #104852

Copy link
Copy Markdown
Member Author

@AlexWaygood: Why did you merged the branch 'main' into remove_pipes? I created this PR 49 minutes ago. Do you expect regressions since main changed in the meanwhile? I was awaiting CI tests to complete, and with this merge I have to wait 30 minutes again :-(

hugovk commented May 24, 2023

Copy link
Copy Markdown
Member

I expect it's to include the doctest fix #104852 from main, so we can get a nice clean (green) slate here.

AlexWaygood commented May 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@vstinner sorry if I was unhelpful. The doctest CI check was failing on this PR for an unrelated reason; after Hugo merged his fix for the doctest failure into main, I thought I could retrigger the check for you here by merging main into this PR branch. But, since it wasn't a "required" check, you probably could have merged the PR anyway, despite the CI check being red. My bad — sorry again :-)

hugovk commented May 24, 2023

Copy link
Copy Markdown
Member

By the way, we've now made available GitHub's "Enable auto-merge" feature for this repo, so this could be a good opportunity to give it a spin:

https://devguide.python.org/getting-started/git-boot-camp/#accepting-and-merging-a-pull-request

Copy link
Copy Markdown
Member Author

The doctest CI check was failing on this PR

Oh, I didn't see. In that case, thank you :-) I was just surprised to see a merge without any explanation.

Copy link
Copy Markdown
Member

I was just surprised to see a merge without any explanation.

Apologies — I'll explain my actions next time 😄

vstinner merged commit a4b7e9d into python:main May 24, 2023
vstinner deleted the remove_pipes branch May 24, 2023 11:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL