gh-102856: Add missing quote to fix doctest - #104852
Merged
hugovk merged 1 commit intoMay 24, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
4 tasks
This was referenced May 24, 2023
AlexWaygood
approved these changes
May 24, 2023
Copy link
Copy Markdown
Contributor
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 24, 2023
(cherry picked from commit 3e97c00) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-104854 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document: whatsnew/3.12 ----------------------- ********************************************************************** File "whatsnew/3.12.rst", line ?, in default Failed example: f"This is the playlist: {", ".join(songs)}" Expected: 'This is the playlist: Take me back to Eden, Alkaline, Ascensionism Got: 'This is the playlist: Take me back to Eden, Alkaline, Ascensionism' ********************************************************************** 1 items had failures: 1 of 12 in default 12 tests in 1 items. 11 passed and 1 failed. ***Test Failed*** 1 failures.https://github.com/python/cpython/actions/runs/5066957137/jobs/9097400760
Introduced in #104824.