FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104866: Tokenize should emit NEWLINE after exiting block with comment by lysnikolaou · Pull Request #104870 · python/cpython · GitHub

/ cpython Public

gh-104866: Tokenize should emit NEWLINE after exiting block with comment - #104870

Merged
pablogsal merged 1 commit into
python:mainfrom
lysnikolaou:tokenize-nl-newline-comment
May 24, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-104866: Tokenize should emit NEWLINE after exiting block with comment#104870
pablogsal merged 1 commit into
python:mainfrom
lysnikolaou:tokenize-nl-newline-comment

Conversation

lysnikolaou commented May 24, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

lysnikolaou requested a review from pablogsal as a code owner May 24, 2023 15:44
bedevere-bot mentioned this pull request May 24, 2023
Closed

pablogsal commented May 24, 2023

Copy link
Copy Markdown
Member

Good catch!

pablogsal merged commit c90a862 into python:main May 24, 2023

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
pythongh-104866: Tokenize should emit NEWLINE after exiting block wit…
3c3ea89 
…h comment (pythonGH-104870)

(cherry picked from commit c90a862)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104872 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
terryjreedy pushed a commit that referenced this pull request May 24, 2023
[3.12] gh-104866: Tokenize should emit NEWLINE after exiting block wi…
ddc29c8 
…th comment (GH-104870) (#104872)

gh-104866: Tokenize should emit NEWLINE after exiting block with comment (GH-104870)
(cherry picked from commit c90a862)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
pablogsal mentioned this pull request May 25, 2023
Closed
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL