[3.12] gh-104866: Tokenize should emit NEWLINE after exiting block with comment (GH-104870) - #104872
Merged
terryjreedy merged 2 commits intoMay 24, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…h comment (pythonGH-104870) (cherry picked from commit c90a862) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
This was referenced May 24, 2023
pablogsal
approved these changes
May 24, 2023
Copy link
Copy Markdown
Member
|
@pablogsal @terryjreedy test_idle fails on 3.12 with this. I haven't exactly kept up with what happened there, so it's a bit unclear what we should do about it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Test failures at least mostly due to tokenizer - idlelib criss-crossed backports snafu. Rerunning after updating to get patch just merged. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c90a862)
Co-authored-by: Lysandros Nikolaou lisandrosnik@gmail.com