FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Build docs as part of the MSI test by zooba · Pull Request #104929 · python/cpython · GitHub

/ cpython Public

Build docs as part of the MSI test - #104929

Merged
zooba merged 3 commits into
python:mainfrom
zooba:msitest
May 25, 2023
ConversationCommits (3)ChecksFiles changed
Merged

Build docs as part of the MSI test#104929
zooba merged 3 commits into
python:mainfrom
zooba:msitest

Conversation

zooba commented May 25, 2023

Copy link
Copy Markdown
Member

No description provided.

zooba added tests Tests in the Lib/test dir skip issue skip news labels May 25, 2023
zooba requested review from ezio-melotti and hugovk as code owners May 25, 2023 11:48
zooba mentioned this pull request May 25, 2023
Merged
zooba enabled auto-merge (squash) May 25, 2023 11:50
zooba disabled auto-merge May 25, 2023 12:02
zooba requested a review from a team as a code owner May 25, 2023 12:02
zooba merged commit 569b2b8 into python:main May 25, 2023
zooba added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 25, 2023

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

zooba deleted the msitest branch May 25, 2023 15:17

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 569b2b8d612354062b8679d2d3f44f7ee03e66c2 3.11

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Sorry @zooba, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 569b2b8d612354062b8679d2d3f44f7ee03e66c2 3.12

zooba added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels May 25, 2023

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
Improves the Windows MSI test run on PR (pythonGH-104929)
ca15e6a 
Correctly set the exit code when builds fail
Also build docs as part of the test
(cherry picked from commit 569b2b8)

Co-authored-by: Steve Dower <steve.dower@python.org>

bedevere-bot commented May 25, 2023

Copy link
Copy Markdown

GH-104934 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label May 25, 2023
zooba added a commit that referenced this pull request May 25, 2023
Improves the Windows MSI test run on PR (GH-104929)
d176f78 
Correctly set the exit code when builds fail
Also build docs as part of the test
(cherry picked from commit 569b2b8)

Co-authored-by: Steve Dower <steve.dower@python.org>

bedevere-bot commented May 25, 2023

Copy link
Copy Markdown

GH-104940 is a backport of this pull request to the 3.10 branch.

zooba added a commit that referenced this pull request May 25, 2023
[3.10] Improves the Windows MSI test run on PR (GH-104929)
f22ddbf 
Correctly set the exit code when builds fail
Also build docs as part of the test
zware reviewed May 25, 2023
View reviewed changes

zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM after the fact :)

erlend-aasland mentioned this pull request Jun 6, 2023
Closed
hugovk removed the needs backport to 3.11 only security fixes label Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zware zware left review comments
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

zooba

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL