[3.12] Improves the Windows MSI test run on PR (GH-104929) - #104934
Merged
zooba merged 1 commit intoMay 25, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Correctly set the exit code when builds fail Also build docs as part of the test (cherry picked from commit 569b2b8) Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington
requested review from
a team,
ezio-melotti and
hugovk
as code owners
May 25, 2023 15:17
zooba
approved these changes
May 25, 2023
Copy link
Copy Markdown
Contributor
Author
|
Thanks @miss-islington for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Sorry, @miss-islington and @zooba, I could not cleanly backport this to 3.11 due to a conflict. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly set the exit code when builds fail
Also build docs as part of the test
(cherry picked from commit 569b2b8)
Co-authored-by: Steve Dower steve.dower@python.org