FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104935: typing: Fix interactions between @runtime_checkable and Generic by JelleZijlstra · Pull Request #104939 · python/cpython · GitHub

/ cpython Public

gh-104935: typing: Fix interactions between @runtime_checkable and Generic - #104939

Merged
AlexWaygood merged 5 commits into
python:mainfrom
JelleZijlstra:is_protocol
May 25, 2023
ConversationCommits (5)ChecksFiles changed
Merged

gh-104935: typing: Fix interactions between @runtime_checkable and Generic#104939
AlexWaygood merged 5 commits into
python:mainfrom
JelleZijlstra:is_protocol

Conversation

JelleZijlstra commented May 25, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request May 25, 2023
Closed
AlexWaygood reviewed May 25, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py Outdated
Comment thread Objects/typevarobject.c Outdated
AlexWaygood reviewed May 25, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py
JelleZijlstra and others added 3 commits May 25, 2023 09:12
Update Lib/test/test_typing.py
19bbcb0 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Better approach
f299fbd
Update news
0859dcd
JelleZijlstra changed the title gh-104935: Add back typing.Generic._is_protocol gh-104935: typing: Fix interactions between @runtime_checkable and Generic May 25, 2023
AlexWaygood removed the request for review from markshannon May 25, 2023 16:22
AlexWaygood approved these changes May 25, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks!

AlexWaygood enabled auto-merge (squash) May 25, 2023 16:23
AlexWaygood merged commit 2b7027d into python:main May 25, 2023

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Sorry @JelleZijlstra and @AlexWaygood, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 2b7027d0b2ee2e102a24a0da27d01b8221f9351c 3.12

AlexWaygood added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels May 25, 2023

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

JelleZijlstra removed the needs backport to 3.12 only security fixes label May 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
pythongh-104935: typing: Fix interactions between `@runtime_checkable…
f67a992 
…` and `Generic` (pythonGH-104939)

---------

(cherry picked from commit 2b7027d)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-bot commented May 25, 2023

Copy link
Copy Markdown

GH-104941 is a backport of this pull request to the 3.12 branch.

JelleZijlstra added the needs backport to 3.12 only security fixes label May 25, 2023

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

JelleZijlstra deleted the is_protocol branch May 25, 2023 16:44
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
pythongh-104935: typing: Fix interactions between `@runtime_checkable…
70cc4e5 
…` and `Generic` (pythonGH-104939)

---------

(cherry picked from commit 2b7027d)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

JelleZijlstra commented May 25, 2023

Copy link
Copy Markdown
Member Author

oops

AlexWaygood commented May 25, 2023

Copy link
Copy Markdown
Member

Yeah you made @miss-islington force-push to her PR branch!

AlexWaygood added a commit that referenced this pull request May 25, 2023
[3.12] gh-104935: typing: Fix interactions between `@runtime_checkabl…
930efde 
…e` and `Generic` (GH-104939) (#104941)

gh-104935: typing: Fix interactions between `@runtime_checkable` and `Generic` (GH-104939)

---------

(cherry picked from commit 2b7027d)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
JelleZijlstra restored the is_protocol branch September 10, 2024 23:37
ZeroIntensity removed the needs backport to 3.12 only security fixes label Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes
gvanrossum Awaiting requested review from gvanrossum
Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

AlexWaygood

Labels

topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL