FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-105237: Allow calling `issubclass(X, typing.Protocol)` again by AlexWaygood · Pull Request #105239 · python/cpython · GitHub

/ cpython Public

gh-105237: Allow calling issubclass(X, typing.Protocol) again - #105239

Merged
JelleZijlstra merged 6 commits into
python:mainfrom
AlexWaygood:protocol-subclass-regression
Jun 5, 2023
ConversationCommits (6)ChecksFiles changed
Merged

gh-105237: Allow calling issubclass(X, typing.Protocol) again#105239
JelleZijlstra merged 6 commits into
python:mainfrom
AlexWaygood:protocol-subclass-regression

Conversation

AlexWaygood commented Jun 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

AlexWaygood added type-bug An unexpected behavior, bug, or error skip news stdlib Standard Library Python modules in the Lib/ directory topic-typing needs backport to 3.12 only security fixes labels Jun 2, 2023
bedevere-bot mentioned this pull request Jun 2, 2023
Closed
AlexWaygood commented Jun 2, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py Outdated
AlexWaygood changed the title gh-105237: Allow calling issubclass(X, Protocol) again gh-105237: Allow calling issubclass(X, typing.Protocol) again Jun 2, 2023
JelleZijlstra reviewed Jun 2, 2023
View reviewed changes
Comment thread Lib/typing.py
AlexWaygood requested a review from JelleZijlstra June 2, 2023 14:09
AlexWaygood commented Jun 2, 2023
View reviewed changes
Comment thread Lib/typing.py

AlexWaygood commented Jun 4, 2023

Copy link
Copy Markdown
Member Author

I've run the third-party tests we have at typing_extensions on a version of this PR. In combination with #105281, this causes no regressions.

AlexWaygood mentioned this pull request Jun 4, 2023
Merged
JelleZijlstra merged commit cdfb201 into python:main Jun 5, 2023

miss-islington commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Sorry @AlexWaygood and @JelleZijlstra, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker cdfb201bfa35b7c50de5099c6d9078c806851d98 3.12

JelleZijlstra added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jun 5, 2023

miss-islington commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2023
pythongh-105237: Allow calling issubclass(X, typing.Protocol) again (…
f45b5d7 
…pythonGH-105239)

(cherry picked from commit cdfb201)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

GH-105316 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 5, 2023
AlexWaygood deleted the protocol-subclass-regression branch June 5, 2023 13:37
AlexWaygood added a commit that referenced this pull request Jun 5, 2023
[3.12] gh-105237: Allow calling issubclass(X, typing.Protocol) again (
5175026 
GH-105239) (#105316)

gh-105237: Allow calling `issubclass(X, typing.Protocol)` again (GH-105239)
(cherry picked from commit cdfb201)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
gvanrossum Awaiting requested review from gvanrossum
Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

JelleZijlstra

Labels

stdlib Standard Library Python modules in the Lib/ directory topic-typing type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL