FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-105280: Ensure `isinstance([], collections.abc.Mapping)` always evaluates to `False` by AlexWaygood · Pull Request #105281 · python/cpython · GitHub

/ cpython Public

gh-105280: Ensure isinstance([], collections.abc.Mapping) always evaluates to False - #105281

Merged
AlexWaygood merged 5 commits into
python:mainfrom
AlexWaygood:fix-gc-protocol-bug
Jun 5, 2023
ConversationCommits (5)ChecksFiles changed
Merged

gh-105280: Ensure isinstance([], collections.abc.Mapping) always evaluates to False#105281
AlexWaygood merged 5 commits into
python:mainfrom
AlexWaygood:fix-gc-protocol-bug

Conversation

AlexWaygood commented Jun 4, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

AlexWaygood added type-bug An unexpected behavior, bug, or error stdlib Standard Library Python modules in the Lib/ directory topic-typing needs backport to 3.12 only security fixes labels Jun 4, 2023
bedevere-bot mentioned this pull request Jun 4, 2023
Closed

AlexWaygood commented Jun 4, 2023

Copy link
Copy Markdown
Member Author

I've run the third-party test workflow we have at typing_extensions on a version of this PR, and it doesn't cause any regressions.

This was referenced Jun 4, 2023
Merged
Merged
AlexWaygood commented Jun 5, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py Outdated
AlexWaygood commented Jun 5, 2023
View reviewed changes
Comment thread Lib/typing.py Outdated
AlexWaygood commented Jun 5, 2023
View reviewed changes
Comment thread Lib/typing.py Outdated
AlexWaygood enabled auto-merge (squash) June 5, 2023 13:35
AlexWaygood merged commit 08756db into python:main Jun 5, 2023

miss-islington commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

AlexWaygood deleted the fix-gc-protocol-bug branch June 5, 2023 14:11

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

GH-105318 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2023
pythongh-105280: Ensure isinstance([], collections.abc.Mapping) alw…
c004e38 
…ays evaluates to `False` (pythonGH-105281)

(cherry picked from commit 08756db)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 5, 2023
AlexWaygood added a commit that referenced this pull request Jun 5, 2023
[3.12] gh-105280: Ensure isinstance([], collections.abc.Mapping) al…
2031238 
…ways evaluates to `False` (GH-105281) (#105318)

gh-105280: Ensure `isinstance([], collections.abc.Mapping)` always evaluates to `False` (GH-105281)
(cherry picked from commit 08756db)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
gvanrossum Awaiting requested review from gvanrossum
Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory topic-typing type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL