gh-104783: locale.getencoding() fallback uses FS encoding - #105381
Merged
vstinner merged 1 commit intoJun 6, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The locale.getencoding() function now uses sys.getfilesystemencoding() if _locale.getencoding() is missing, instead of calling locale.getdefaultlocale().
Copy link
Copy Markdown
Member
Author
|
@methane: This change is more a theorical change, since it doesn't affect CPython which always has the _locale extension. But it's needed to prepare the removal of the deprecated locale.getdefaultencoding() function. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I don't think that a Changelog entry is needed, since it doesn't affect CPython users. |
Sorry, something went wrong.
methane
reviewed
Jun 6, 2023
Comment thread
Lib/locale.py
| # LANG not set, default to UTF-8 | ||
| encoding = 'utf-8' | ||
| return encoding | ||
| return _encoding |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
return sys.getfilesystemencoding() would be enough.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I created PR #105401 to change this.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The locale.getencoding() function now uses
sys.getfilesystemencoding() if _locale.getencoding() is missing, instead of calling locale.getdefaultlocale().