gh-104783: locale.getlocale() calls sys.getfilesystemencoding() - #105401
Merged
vstinner merged 1 commit intoJun 6, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
locale.getlocale() always calls sys.getfilesystemencoding(), instead of calling it only once.
Copy link
Copy Markdown
Member
Author
|
@methane: I added _encoding variable to be able to calle locale.getencoding() during Python finalization, when modules attributes are set to None. But maybe it's not needed. By the way, Python tries to keep sys attributes as long as posible. So I wrote this PR to change it :-) |
Sorry, something went wrong.
methane
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
locale.getlocale() always calls sys.getfilesystemencoding(), instead of calling it only once.