Docs fix-up: Remove references to ProcessPoolExecutor from asyncio-dev.rst - #105543
Closed
eirrgang wants to merge 1 commit into
Closed
Docs fix-up: Remove references to ProcessPoolExecutor from asyncio-dev.rst#105543eirrgang wants to merge 1 commit into
eirrgang wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ddd5f36 updated asyncio-eventloop.rst, but overlooked other references to using non-ThreadPoolExecutors with `run_in_executor()`. Ref bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor (pythonGH-24540)
eirrgang
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
June 9, 2023 01:20
Copy link
Copy Markdown
Contributor
Author
|
I think I may have misinterpreted the update and the documentation. It looks like it is only set_default_executor for which ProcessPoolExecutor has been disallowed. A ProcessPoolExecutor instance can still be passed to run_in_executor() as an argument. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ddd5f36 updated asyncio-eventloop.rst, but overlooked other references to using non-ThreadPoolExecutors with run_in_executor().
Ref bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor (GH-24540)
📚 Documentation preview 📚: https://cpython-previews--105543.org.readthedocs.build/