FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor by illia-v · Pull Request #24540 · python/cpython · GitHub

/ cpython Public

bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor - #24540

Merged
serhiy-storchaka merged 6 commits into
python:mainfrom
illia-v:bpo-43234
Jul 1, 2021
ConversationCommits (6)ChecksFiles changed
Merged

bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor#24540
serhiy-storchaka merged 6 commits into
python:mainfrom
illia-v:bpo-43234

Conversation

illia-v commented Feb 15, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Mar 18, 2021
serhiy-storchaka requested changes Jun 28, 2021
View reviewed changes
Comment thread Doc/library/asyncio-eventloop.rst Outdated
Comment thread Doc/library/asyncio-eventloop.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Lib/asyncio/base_events.py Outdated

bedevere-bot commented Jun 28, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

serhiy-storchaka removed the stale Stale PR or inactive for long period of time. label Jun 28, 2021
illia-v and others added 4 commits June 29, 2021 17:19

illia-v commented Jun 29, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Jun 29, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

illia-v commented Jun 29, 2021

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka if you have a chance, please take a look at #24525 too

serhiy-storchaka reviewed Jun 30, 2021
View reviewed changes
Comment thread Lib/test/test_asyncio/test_base_events.py Outdated
Comment thread Lib/test/test_asyncio/test_base_events.py Outdated
Update a related test
d5934a0 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

illia-v commented Jun 30, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Jun 30, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka approved these changes Jul 1, 2021
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

serhiy-storchaka merged commit ddd5f36 into python:main Jul 1, 2021
eirrgang added a commit to eirrgang/cpython that referenced this pull request Jun 9, 2023
Remove references to ProcessPoolExecutor from asyncio-dev.rst
0b3e1b6 
ddd5f36 updated asyncio-eventloop.rst, but overlooked other references to using non-ThreadPoolExecutors with `run_in_executor()`.

Ref bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor (pythonGH-24540)
eirrgang mentioned this pull request Jun 9, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL