Fix confusion of enum _framestate with enum _frameowner - #106156
Closed
andersk wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The owner field of _PyInterpreterFrame is supposed to be a member of enum _frameowner, but FRAME_CLEARED is a member of enum _framestate. Add FRAME_OWNED_BY_ACCIDENT to enum _frameowner and use that instead. (It happens to have the same numerical value, but we shouldn’t rely on that anywhere.) Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
frame-enum-confusion
branch
from
1fc0752 to
b3a6775
Compare
March 3, 2024 19:15
rruuaanng
reviewed
Sep 16, 2024
Comment thread
Include/internal/pycore_frame.h
| FRAME_OWNED_BY_GENERATOR = 1, | ||
| FRAME_OWNED_BY_FRAME_OBJECT = 2, | ||
| FRAME_OWNED_BY_CSTACK = 3, | ||
| FRAME_OWNED_BY_ACCIDENT = 4, |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Maybe you should add a NEWS describing that you added a new value to the enum_frameowner enumeration in pycore_frame.h.
I think that making modifications to the interpreter core requires adding.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This is not part of the public API; it’s an internal fix that has no direct relevance to Python users or extension authors.
However, the surrounding code has changed, so I’m closing this in favor of
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner field of _PyInterpreterFrame is supposed to be a member of enum _frameowner, but FRAME_CLEARED is a member of enum _framestate. Add FRAME_OWNED_BY_ACCIDENT to enum _frameowner and use that instead. (It happens to have the same numerical value, but we shouldn’t rely on that anywhere.)