Remove asserts that confuse enum _framestate with enum _frameowner - #124148
Remove asserts that confuse enum _framestate with enum _frameowner#124148colesbury merged 3 commits into
Conversation
Sorry, something went wrong.
The owner field of _PyInterpreterFrame is supposed to be a member of enum _frameowner, but FRAME_CLEARED is a member of enum _framestate. At present, it happens that FRAME_CLEARED is not numerically equal to any member of enum _frameowner, but that could change in the future. The code that incorrectly assigned owner = FRAME_CLEARED was deleted in commit a53cc3f (pythonGH-116687). Remove the incorrect checks for owner != FRAME_CLEARED as well. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
colesbury
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
brandtbucher
left a comment
There was a problem hiding this comment.
Yup, makes sense. Nice catch.
Sorry, something went wrong.
|
Thanks @andersk for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
|
Sorry, @andersk and @colesbury, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker a626f9a67b76e5fe69677afd5f8317d8c61de8de 3.13 |
Sorry, something went wrong.
|
Sorry, @andersk and @colesbury, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker a626f9a67b76e5fe69677afd5f8317d8c61de8de 3.12 |
Sorry, something went wrong.
|
Backports didn't apply cleanly and we didn't backport #116687, so I figure it's probably not worth backporting this after all. |
Sorry, something went wrong.
pythonGH-124148) The `owner` field of `_PyInterpreterFrame` is supposed to be a member of `enum _frameowner`, but `FRAME_CLEARED` is a member of `enum _framestate`. At present, it happens that `FRAME_CLEARED` is not numerically equal to any member of `enum _frameowner`, but that could change in the future. The code that incorrectly assigned `owner = FRAME_CLEARED` was deleted in commit a53cc3f (pythonGH-116687). Remove the incorrect checks for `owner != FRAME_CLEARED` as well.
The owner field of _PyInterpreterFrame is supposed to be a member of enum _frameowner, but FRAME_CLEARED is a member of enum _framestate. At present, it happens that FRAME_CLEARED is not numerically equal to any member of enum _frameowner, but that could change in the future. The code that incorrectly assigned owner = FRAME_CLEARED was deleted in commit a53cc3f (GH-116687). Remove the incorrect checks for owner != FRAME_CLEARED as well.