FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106693: Explicitly mark ob_sval as unsigned char to avoid UB by pablogsal · Pull Request #106826 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-106693: Explicitly mark ob_sval as unsigned char to avoid UB - #106826

Merged
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-106693
May 7, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-106693: Explicitly mark ob_sval as unsigned char to avoid UB#106826
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-106693

Conversation

pablogsal commented Jul 17, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal added the needs backport to 3.12 only security fixes label Jul 17, 2023
bedevere-bot mentioned this pull request Jul 17, 2023
Open
pythongh-106693: Explicitly mark ob_sval as unsigned char to avoid UB
eecd6a8 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
serhiy-storchaka added the needs backport to 3.13 only security fixes label May 9, 2024
tomasr8 removed the needs backport to 3.12 only security fixes label Apr 10, 2025
serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
pablogsal enabled auto-merge (squash) September 19, 2025 10:14

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 13, 2026
pablogsal merged commit fbba343 into python:main May 7, 2026
19 of 45 checks passed
pablogsal deleted the gh-106693 branch May 7, 2026 19:06

miss-islington-app Bot commented May 7, 2026

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

bedevere-app Bot commented May 7, 2026

Copy link
Copy Markdown

GH-149510 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 7, 2026

bedevere-app Bot commented May 7, 2026

Copy link
Copy Markdown

GH-149511 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 7, 2026

colesbury commented May 7, 2026

Copy link
Copy Markdown
Contributor

@pablogsal I might be missing something, but it looks like this breaks a bunch of builds. Doesn't it also have a bunch backwards compatibility concerns? The theoretically fixes undefined behavior seems less important than the actual breaks backwards compatibility

pablogsal commented May 7, 2026

Copy link
Copy Markdown
Member Author

I didn't merge this myself so I don't know what the hell happened here

pablogsal commented May 7, 2026

Copy link
Copy Markdown
Member Author

(Apparently this is a consequence of deactivating branch protections in the release)

hugovk added a commit that referenced this pull request May 7, 2026
gh-106693: Revert "Explicitly mark ob_sval as unsigned char to avoid …
f0daba1 
…UB (#106826)" (#149514)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL