Repository navigation
gh-106693: Revert "Explicitly mark ob_sval as unsigned char to avoid UB (#106826)" - #149514
Merged
hugovk merged 2 commits intoMay 7, 2026
Merged
hugovk merged 2 commits into
hugovk merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…avoid UB (python#106826)" This reverts commit fbba343.
pablogsal
approved these changes
May 7, 2026
pablogsal
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🤠
Sorry, something went wrong.
…all" (pythonGH-138555)" This reverts commit 310fe88.
StanFromIreland
approved these changes
May 7, 2026
StanFromIreland
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks Hugo!
Sorry, something went wrong.
This was referenced Jul 5, 2026
Merged
Merged
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 5, 2026
… all" (GH-152525) (GH-153109) This change was accidentally reverted by f0daba1 (gh-106693, GH-149514), which only intended to revert the ob_sval change. The tests were already restored by GH-149569. (cherry picked from commit 70100b9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 5, 2026
… all" (GH-152525) (GH-153108) This change was accidentally reverted by f0daba1 (gh-106693, GH-149514), which only intended to revert the ob_sval change. The tests were already restored by GH-149569. (cherry picked from commit 70100b9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 5, 2026
… all" (GH-152525) (GH-153107) This change was accidentally reverted by f0daba1 (gh-106693, GH-149514), which only intended to revert the ob_sval change. The tests were already restored by GH-149569. (cherry picked from commit 70100b9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Aug 8, 2026
…all" This change was accidentally reverted by f0daba1 (pythongh-106693, pythonGH-149514), which only intended to revert the ob_sval change. The tests were already restored by pythonGH-149569. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fbba343 and 310fe88.
Was set to automerge 8 months, and three days ago, respectively, but weren't meant to merge right now.
I'd temporarily removed branch protection to be able to merge #149500 which was needed to fix configure.