FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-79638: Test other HTTP error codes besides 403 in test_robotparser by serhiy-storchaka · Pull Request #149569 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-79638: Test other HTTP error codes besides 403 in test_robotparser - #149569

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:robotparser-test-http-errors
May 8, 2026
ConversationCommits (5)ChecksFiles changed
Merged

gh-79638: Test other HTTP error codes besides 403 in test_robotparser#149569
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:robotparser-test-http-errors

Conversation

serhiy-storchaka commented May 8, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels May 8, 2026
bedevere-app Bot added the tests Tests in the Lib/test dir label May 8, 2026
bedevere-app Bot mentioned this pull request May 8, 2026
Closed
serhiy-storchaka force-pushed the robotparser-test-http-errors branch from 689e226 to 0aa7bac Compare May 8, 2026 16:53
serhiy-storchaka enabled auto-merge (squash) May 8, 2026 19:58

serhiy-storchaka commented May 8, 2026

Copy link
Copy Markdown
Member Author

The problem was in the missed clean up in NetworkTestCase. It was compensated by calling in PasswordProtectedSiteTestCase, but after renaming the latter to HttpErrorsTestCase, it is now executed before NetworkTestCase.

serhiy-storchaka merged commit 57ef219 into python:main May 8, 2026
49 checks passed

miss-islington-app Bot commented May 8, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented May 8, 2026

Copy link
Copy Markdown

GH-149580 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label May 8, 2026

bedevere-app Bot commented May 8, 2026

Copy link
Copy Markdown

GH-149581 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 8, 2026

bedevere-app Bot commented May 8, 2026

Copy link
Copy Markdown

GH-149582 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 8, 2026
serhiy-storchaka deleted the robotparser-test-http-errors branch May 8, 2026 20:28
serhiy-storchaka added a commit that referenced this pull request May 8, 2026
[3.13] gh-79638: Test other HTTP error codes besides 403 in test_robo…
ba894f1 
…tparser (GH-149569) (GH-149582)

Also, use urllib.request.urlcleanup() in NetworkTestCase.
(cherry picked from commit 57ef219)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request May 8, 2026
[3.14] gh-79638: Test other HTTP error codes besides 403 in test_robo…
92d323a 
…tparser (GH-149569) (GH-149581)

Also, use urllib.request.urlcleanup() in NetworkTestCase.
(cherry picked from commit 57ef219)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request May 8, 2026
[3.15] gh-79638: Test other HTTP error codes besides 403 in test_robo…
bb060b8 
…tparser (GH-149569) (GH-149580)

Also, use urllib.request.urlcleanup() in NetworkTestCase.
(cherry picked from commit 57ef219)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka mentioned this pull request Jun 28, 2026
Merged
serhiy-storchaka added a commit that referenced this pull request Jul 5, 2026
gh-79638: Restore "Treat an unreachable robots.txt as disallow all" (G…
70100b9 
…H-152525)

This change was accidentally reverted by f0daba1 (gh-106693,
GH-149514), which only intended to revert the ob_sval change.
The tests were already restored by GH-149569.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 5, 2026
Merged
Merged
Merged
serhiy-storchaka added a commit that referenced this pull request Jul 5, 2026
[3.13] gh-79638: Restore "Treat an unreachable robots.txt as disallow…
d35cfee 
… all" (GH-152525) (GH-153109)

This change was accidentally reverted by f0daba1 (gh-106693,
GH-149514), which only intended to revert the ob_sval change.
The tests were already restored by GH-149569.
(cherry picked from commit 70100b9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jul 5, 2026
[3.14] gh-79638: Restore "Treat an unreachable robots.txt as disallow…
a624878 
… all" (GH-152525) (GH-153108)

This change was accidentally reverted by f0daba1 (gh-106693,
GH-149514), which only intended to revert the ob_sval change.
The tests were already restored by GH-149569.
(cherry picked from commit 70100b9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jul 5, 2026
[3.15] gh-79638: Restore "Treat an unreachable robots.txt as disallow…
2a5f9e0 
… all" (GH-152525) (GH-153107)

This change was accidentally reverted by f0daba1 (gh-106693,
GH-149514), which only intended to revert the ob_sval change.
The tests were already restored by GH-149569.
(cherry picked from commit 70100b9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 8, 2026
pythongh-79638: Restore "Treat an unreachable robots.txt as disallow …
b9466eb 
…all"

This change was accidentally reverted by f0daba1 (pythongh-106693,
pythonGH-149514), which only intended to revert the ob_sval change.
The tests were already restored by pythonGH-149569.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL